Implement PackageScanner service #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## scanner #170 +/- ##
=============================================
- Coverage 99.87% 99.86% -0.02%
- Complexity 1177 1273 +96
=============================================
Files 203 215 +12
Lines 3332 3613 +281
=============================================
+ Hits 3328 3608 +280
- Misses 4 5 +1
Continue to review full report at Codecov.
|
akondas
reviewed
May 22, 2020
| $this->packageRepository->getById(Uuid::fromString($item->id())) | ||
| ); | ||
| $progressBar->advance(); | ||
| } |
There was a problem hiding this comment.
We need to call EntityManager::clear to reduce memory usage, and use transaction here
akondas
reviewed
May 22, 2020
| return $this->formatContent(); | ||
| } | ||
|
|
||
| public function htmlSimple(): string |
There was a problem hiding this comment.
I would like to rename this method and maybe we can remove html from readl model?
I know it simplifies, but it's not their responsibility to format html.
akondas
reviewed
May 22, 2020
| /** | ||
| * @param Advisory[] $advisories | ||
| */ | ||
| private function advisoriesHtml(array $advisories): string |
akondas
reviewed
May 22, 2020
| SELECT content FROM organization_package_scan_result s | ||
| WHERE s.package_id = p.id | ||
| ORDER BY date DESC LIMIT 1 | ||
| ) scan_result_content |
There was a problem hiding this comment.
we need to rewrite this query, fortunately, we have already agreed on a better solution
akondas
approved these changes
May 22, 2020
akondas
pushed a commit
that referenced
this pull request
May 28, 2020
* Implement PackageScanner service * Remove php 7.4.3 constant
karniv00l
added a commit
that referenced
this pull request
May 28, 2020
* Implement PackageScanner service (#170) * Implement PackageScanner service * Remove php 7.4.3 constant * Implement SecurityChecker (#171) * Implement SecurityChecker * Remove unused class; Load advisories only when var is empty * Add `repman:security:update-db` command to cron (#176) * Add last scan result to package model (#177) * Add last scan result to package entity * Disable command output * Get rid of html from read model * Update db command (#178) * Scan all packages when database is updated * CR fixes * Add expectations * Fix update advisories database git command (#182) * Fix update advisories database git command * Add git config for buddy pipeline Co-authored-by: Piotr Rogowski <piotr.rogowski0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.