Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permissions: fix permissions on the configuration #287

Merged
merged 1 commit into from
Oct 26, 2020
Merged

permissions: fix permissions on the configuration #287

merged 1 commit into from
Oct 26, 2020

Conversation

Garfield-fr
Copy link
Contributor

  • Fixes observable for input permissions on the route data configuration.

Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?

@Garfield-fr
permissions: fix permissions on the configuration
112296d 
* Fixes observable for input permissions on the route data configuration.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
iGormilhit
iGormilhit approved these changes Oct 26, 2020
View reviewed changes
Copy link

@iGormilhit iGormilhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message approved.

@Garfield-fr Garfield-fr mentioned this pull request Oct 26, 2020
Merged
6 tasks
zannkukai
zannkukai approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It begins difficult to read the code with all these observables in all senses ;-)

@Garfield-fr Garfield-fr merged commit 20852f8 into rero:dev Oct 26, 2020
@Garfield-fr Garfield-fr deleted the zub-record-permissions branch October 26, 2020 09:08
@sebdeleze sebdeleze mentioned this pull request Nov 2, 2020
Merged
sebdeleze pushed a commit that referenced this pull request Nov 2, 2020
files: fix metadata edition
a6e8e53 
Fixes a detection change error when metadata field is removed from form (hidden).

* Subscribes to modal's hide event to properly clean data.
* Does not display file's info, when metadata are edited, to avoid a detection change error.
* Updates `ngx-formly` to version 5.10.6
* Changes the return of permissions in tester, to avoid an error after merging #287.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iGormilhit iGormilhit iGormilhit approved these changes

@sebdeleze sebdeleze sebdeleze approved these changes

@zannkukai zannkukai zannkukai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garfield-fr @iGormilhit @sebdeleze @zannkukai