Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: fix metadata edition #294

Merged
merged 1 commit into from
Nov 2, 2020
Merged

files: fix metadata edition #294

merged 1 commit into from
Nov 2, 2020

Conversation

sebdeleze
Copy link

Fixes a detection change error when metadata field is removed from form (hidden).

  • Subscribes to modal's hide event to properly clean data.
  • Does not display file's info, when metadata are edited, to avoid a detection change error.
  • Updates ngx-formly to version 5.10.6
  • Changes the return of permissions in tester, to avoid an error after merging permissions: fix permissions on the configuration #287.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

@sebdeleze sebdeleze marked this pull request as ready for review November 2, 2020 13:08
Fixes a detection change error when metadata field is removed from form (hidden).

* Subscribes to modal's hide event to properly clean data.
* Does not display file's info, when metadata are edited, to avoid a detection change error.
* Updates `ngx-formly` to version 5.10.6
* Changes the return of permissions in tester, to avoid an error after merging #287.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze merged commit a6e8e53 into rero:dev Nov 2, 2020
@sebdeleze sebdeleze deleted the sed-fix-files-metadata branch November 2, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants