editor: add email validator #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
May 30, 2022
lauren-d
approved these changes
May 31, 2022
7 tasks
Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
zannkukai
force-pushed
the
zub-email-validator
branch
from
7a79afe to
765a325
Compare
jma
approved these changes
Jun 2, 2022
| field.validators.email = { | ||
| expression: (control: AbstractControl) => !control.value | ||
| ? true : (new RegExp(emailPattern)).test(control.value), | ||
| message: `This value is not a valid email.`, |
|
|
||
| export function emailValidator(field: FormlyFieldConfig) { | ||
| // Regex pattern to check email | ||
| const emailPattern = /^([A-Za-z0-9\._%+-]+@[A-Za-z0-9\.-]+\.[A-Z|a-z]{2,})$/; |
There was a problem hiding this comment.
A comment to explain what is supported and what is not would be great.
| import { AbstractControl } from '@angular/forms'; | ||
| import { FormlyFieldConfig } from '@ngx-formly/core'; | ||
|
|
||
| export function emailValidator(field: FormlyFieldConfig) { |
There was a problem hiding this comment.
It can be a good idea to write some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
Why are you opening this PR?
How to test?
Code review check list