Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forms: add email validation behavior #861

Merged
merged 1 commit into from
Jun 10, 2022
Merged

forms: add email validation behavior #861

merged 1 commit into from
Jun 10, 2022

Conversation

zannkukai
Copy link
Contributor

@zannkukai zannkukai commented May 31, 2022 •
edited
Loading

Updates form fields related to email to directly validate an email
address without submitting the form.

Co-authored-by: Renaud Michotte renaud.michotte@gmail.com

dependencies

rero/ng-core#499

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Cypress tests successful?

@zannkukai zannkukai requested review from Garfield-fr and jma May 31, 2022 07:25
@zannkukai zannkukai self-assigned this May 31, 2022
@github-actions github-actions bot added f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: user management labels May 31, 2022
@zannkukai zannkukai requested a review from vgranata May 31, 2022 07:25
@zannkukai
forms: add email validation behavior
aa08663 
Updates form fields related to email to directly validate an email
address without submitting the form.
Update ports used for `public-user_profile-edit` and
`public-user-password-change` projects in angular settings.

Co-authored-by: Renaud Michotte <renaud.michotte@gmail.com>
@zannkukai zannkukai force-pushed the zan-fix-email-validation branch from 239615e to aa08663 Compare June 2, 2022 07:42
@zannkukai zannkukai merged commit 1b8cd0f into rero:staging Jun 10, 2022
@zannkukai zannkukai deleted the zan-fix-email-validation branch June 10, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield-fr Garfield-fr Garfield-fr approved these changes

@jma jma jma approved these changes

@benerken benerken benerken approved these changes

@vgranata vgranata Awaiting requested review from vgranata

Assignees

@zannkukai zannkukai

Labels
f: editor Concerns editor based on JSON schema AND custom editor f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zannkukai @Garfield-fr @jma @benerken