Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The non required fields of the document editor should support default values. #1119

Closed
pronguen opened this issue Jul 29, 2020 · 1 comment · Fixed by rero/ng-core#291 or #1338
Closed

The non required fields of the document editor should support default values. #1119

pronguen opened this issue Jul 29, 2020 · 1 comment · Fixed by rero/ng-core#291 or #1338
Labels
bug Breaks something but is not blocking enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor
Milestone
v0.13.1

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 29, 2020 •
edited
Loading

How it works

Currently in the document editor, only required fields (displayed by default when opening the editor) integrate default values. When another field is added manually, it does not have default values.

Improvement suggestion

When a field is added manually, it should be able to integrate default values.
@pronguen pronguen added enhancement Improvement of an existing feature triage labels Jul 29, 2020
@jma
Copy link
Contributor

jma commented Aug 5, 2020 •
edited
Loading

Other editor bugs improvements:

  • translation label for hidden properties (ngx-formly)
  • support for hidden sub properties for multischema (oneOf)
  • remove value for hiddenExpression = true when a field becomes hidden (ngx-formly?)
  • populate the field with default value when the field is show (ngx-formly?)
  • head support for simple type of first level
  • id (multischema) and key (multischema objects) for oneOf, anyOf, allOf (ngx-formly).

@jma jma added the f: editor Concerns editor based on JSON schema AND custom editor label Aug 5, 2020
@iGormilhit iGormilhit added bug Breaks something but is not blocking and removed triage labels Aug 10, 2020
@iGormilhit iGormilhit added this to the v0.13.0 milestone Aug 11, 2020
@iGormilhit iGormilhit mentioned this issue Aug 17, 2020
Merged
7 tasks
@pronguen pronguen modified the milestones: v0.13.0, v0.14.0 Oct 21, 2020
@jma jma mentioned this issue Oct 28, 2020
Merged
7 tasks
jma added a commit to jma/ng-core that referenced this issue Oct 28, 2020
@jma
editor: restore default value for hidden field
a0360c6 
* Sets ngx-formly to restore default value when a field is shown.
* Removes useless reset value as it is now done by formly.
* Needs to hide/show field onPopulate in a next event loop statement.
* Adds a new hide wrapper as `hideExpression` does not keep the value in
  the form the model.
* Closes rero/rero-ils#1119.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@jma jma mentioned this issue Oct 28, 2020
Merged
6 tasks
jma added a commit to jma/ng-core that referenced this issue Oct 28, 2020
@jma
editor: restore default value for hidden field
f04ade5 
* Sets ngx-formly to restore default value when a field is shown.
* Removes useless reset value as it is now done by formly.
* Needs to hide/show field onPopulate in a next event loop statement.
* Adds a new hide wrapper as `hideExpression` does not keep the value in
  the form the model.
* Closes rero/rero-ils#1119.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Oct 29, 2020
@jma
editor: restore default value for hidden field
09d491d 
* Sets ngx-formly to restore default value when a field is shown.
* Removes useless reset value as it is now done by formly.
* Needs to hide/show field onPopulate in a next event loop statement.
* Adds a new hide wrapper as `hideExpression` does not keep the value in
  the form the model.
* Closes rero/rero-ils#1119.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/ng-core that referenced this issue Oct 30, 2020
@jma
editor: restore default value for hidden field
ea02bb9 
* Sets ngx-formly to restore default value when a field is shown.
* Removes useless reset value as it is now done by formly.
* Needs to hide/show field onPopulate in a next event loop statement.
* Adds a new hide wrapper as `hideExpression` does not keep the value in
  the form the model.
* Closes rero/rero-ils#1119.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to rero/ng-core that referenced this issue Nov 2, 2020
@jma
editor: restore default value for hidden field
672de40 
* Sets ngx-formly to restore default value when a field is shown.
* Removes useless reset value as it is now done by formly.
* Needs to hide/show field onPopulate in a next event loop statement.
* Adds a new hide wrapper as `hideExpression` does not keep the value in
  the form the model.
* Closes rero/rero-ils#1119.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@iGormilhit iGormilhit modified the milestones: v0.14.0, v0.13.1 Nov 2, 2020
jma added a commit to jma/rero-ils that referenced this issue Nov 2, 2020
@jma
editor: restore default value for hidden field
c913c94 
* Updates JSONSchema to add default values for the editor.
* Changes the way to hide a field in the editor.
* Closes rero#1119.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit to jma/rero-ils that referenced this issue Nov 2, 2020
@jma
editor: restore default value for hidden field
af9470e 
* Updates JSONSchema to add default values for the editor.
* Changes the way to hide a field in the editor.
* Closes rero#1119.
* Upgrades lxml and cryptography dependencies for security reasons.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
jma added a commit that referenced this issue Nov 2, 2020
@jma
editor: restore default value for hidden field
7f74408 
* Updates JSONSchema to add default values for the editor.
* Changes the way to hide a field in the editor.
* Closes #1119.
* Upgrades lxml and cryptography dependencies for security reasons.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor
Projects
None yet
Milestone
v0.13.1
3 participants
@jma @iGormilhit @pronguen