editor: fix hidden field with value from the model #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
approved these changes
Aug 6, 2020
Garfield-fr
approved these changes
Aug 6, 2020
jma
force-pushed
the
maj-remove-hack
branch
2 times, most recently
from
6313b74 to
80da232
Compare
zannkukai
approved these changes
Aug 6, 2020
rerowep
approved these changes
Aug 6, 2020
|
@jma I think this PR closes rero/rero-ils#1119, at least the main part of if. |
sebdeleze
approved these changes
Aug 17, 2020
| @@ -62,6 +62,7 @@ export class ArrayTypeComponent extends FieldArrayType implements OnInit { | |||
| const numberOfItemsToRemove = this.field.fieldGroup.length - minItems; | |||
| // remove the extra elements | |||
| // force removing the elements in the next event loop else this cause errors when removing multiple values | |||
| // TODO: try to remove this hack | |||
| setTimeout(() => { | |||
iGormilhit
reviewed
Aug 18, 2020
There was a problem hiding this comment.
Commit message: Some fields containing values given with the input model, "given with" is not clear, I think. Maybe "coming from"?
Typo in the commit message: As ngx formly made the think cleaner these hacks have been removed. to `As ngx formly made the think cleaner these hacks have
been removed.
And do not forget to close the related issue: #234 (comment)
jma
force-pushed
the
maj-remove-hack
branch
3 times, most recently
from
5890107 to
4d56ab1
Compare
sebdeleze
approved these changes
Aug 18, 2020
Some fields containing values comming from the input model should be visible after the editor initialization. This is not the case with a recent version of ngx formly. This is due to the use of bad hack `setTimeout` at several places in the code. As ngx formly made the think cleaner these hacks have been removed. * Cleans hidden field list at the component destruction instead of initialization. * Reloads the JSONSchema once the model has changed. * Rewrites the add field component by using observers only. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields containing values given with the input model should be visible
after the editor initializations. This is not the case with a recent version of
ngx formly. This is due to the use of bad hack
setTimeoutat severalplaces in the code. As ngx formly made the think cleaner these hacks have
been removed.
initialization.
hidden only when the values are reset.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch
Why are you opening this PR?
rero-ils-uiproject.How to test?
rero-ils-uistart the admin server, import a record from the BNF containing adimensionsvalue. This field should not be hidden. Check that not error is present in the console.Code review check list