Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Node::simulate_click not centering cursor over widget #4

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Fix Node::simulate_click not centering cursor over widget #4

merged 6 commits into from
Nov 28, 2024

Conversation

lucasmerlin
Copy link
Collaborator

No description provided.

emilk
emilk approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does kittest need a test? :P

@lucasmerlin
Copy link
Collaborator Author

Does kittest need a test? :P

It definitely does, turns out the center calculation wasn't correct either 😅

@lucasmerlin lucasmerlin force-pushed the fix-simulate-click-not-moving-cursor branch from f718f70 to 3017426 Compare November 28, 2024 13:20
@lucasmerlin lucasmerlin merged commit 06e01f1 into main Nov 28, 2024
6 checks passed
@lucasmerlin lucasmerlin deleted the fix-simulate-click-not-moving-cursor branch November 28, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmerlin @emilk