Skip to content

Commit

Permalink
Factor out NearClipPlane from VisualBounds2D (#8433)
Browse files Browse the repository at this point in the history
### Related

<!--
Include links to any related issues/PRs in a bulleted list, for example:
* Closes #1234
* Part of #1337
-->
* Closes #8415 

### What

Title.

It looks like we never had a fallback provider for `NearClipPlane`.
@Wumpf can you please confirm that this is correct? 🙏

<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->
  • Loading branch information
grtlr authored Dec 13, 2024
1 parent ad6b151 commit 0c13f96
Show file tree
Hide file tree
Showing 23 changed files with 409 additions and 114 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
namespace rerun.blueprint.archetypes;

/// Controls the distance to the near clip plane in 3D scene units.
table NearClipPlane (
"attr.docs.unreleased",
"attr.rerun.scope": "blueprint",
"attr.rust.derive": "Copy"
) {
/// Controls the distance to the near clip plane in 3D scene units.
///
/// Content closer than this distance will not be visible.
near_clip_plane: rerun.blueprint.components.NearClipPlane ("attr.rerun.component_optional", order: 1000);
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
namespace rerun.blueprint.archetypes;


/// Controls the visual bounds of a 2D view.
///
/// Everything within these bounds are guaranteed to be visible.
Expand All @@ -16,9 +15,4 @@ table VisualBounds2D (
///
/// Use this to control pan & zoom of the view.
range: rerun.blueprint.components.VisualBounds2D ("attr.rerun.component_required", order: 1000);

/// Controls the distance to the near clip plane in 3D scene units.
///
/// Content closer than this distance will not be visible.
near_clip_plane: rerun.blueprint.components.NearClipPlane ("attr.rerun.component_optional", order: 2000);
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions crates/store/re_types/src/blueprint/archetypes/mod.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

186 changes: 186 additions & 0 deletions crates/store/re_types/src/blueprint/archetypes/near_clip_plane.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

63 changes: 8 additions & 55 deletions crates/store/re_types/src/blueprint/archetypes/visual_bounds2d.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0c13f96

Please sign in to comment.