Don't bury the analytics command #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
approved these changes
Feb 13, 2023
grtlr
added a commit
that referenced
this pull request
Nov 29, 2024
### Related * This is one of the big action items of #7897 <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> ### What <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. --> It changes two things: 1. Instead of using multiple `egui::Areas`, we now only have a single top-level area. 2. We compute the sizes of the nodes (information that is important to the layout) in a single preprocessing path instead of the weird frame-to-frame computation that we did before. Overall this will improve code quality, performance, and will unlock new GraphViz-like layout algorithms (which require defined label size from the beginning) down the road. --------- Co-authored-by: Antoine Beyeler <antoine@rerun.io>
grtlr
added a commit
that referenced
this pull request
Dec 3, 2024
### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * Closes: #8238 ### What This PR brings self-edges in the form of Bezier-curves. <img width="230" alt="image" src="https://github.com/user-attachments/assets/85304534-891b-415d-ab8e-3006afe73058"> It also tries to make multiple edges between the same node more legible by applying a small arc on such edges to prevent overlap. <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
grtlr
added a commit
that referenced
this pull request
Dec 4, 2024
### Related * Closes #8282 <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> ### What We made the decision to carry over layout information between timestamps as it leads to a much nicer user experience. This PR implements that feature. @abey79 Some of the logic in `provider.rs` has to change again for blueprint support. I plan to do a cleanup pass in #8299. https://github.com/user-attachments/assets/ae5b8c8e-9482-452c-bcf0-feb73fc165f0 <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. --> --------- Co-authored-by: Antoine Beyeler <49431240+abey79@users.noreply.github.com> Co-authored-by: Andreas Reich <andreas@rerun.io> Co-authored-by: Jan Procházka <honza.spacir@gmail.com>
grtlr
added a commit
that referenced
this pull request
Dec 4, 2024
### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * Closes #8279. ### What Title. <img width="330" alt="image" src="https://github.com/user-attachments/assets/c2f0e65e-d532-41ca-a1b9-6d0f758c78a6"> <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
emilk
pushed a commit
that referenced
this pull request
Dec 6, 2024
### Related * Closes #7842 <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> ### What Simply migrates `re_video` from `store` to `utils`, and accordingly updates `Cargo.toml`. #### Passes: - `cargo test --all-targets --all-features` - `pixi run -e cpp cpp-test` #### Fails: - `pixi run py-test` ``` rerun_py/rerun_sdk/rerun/datatypes/angle.py:12: in <module> import pyarrow as pa .pixi/envs/py/lib/python3.11/site-packages/pyarrow/__init__.py:65: in <module> import pyarrow.lib as _lib E ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by /home/abhishek/Code/rerun/.pixi/envs/py/lib/python3.11/site-packages/pyarrow/../../../libarrow.so.1800) ``` I'm on Ubuntu 22.04 and have got ROS2 which may be causing conflicts as I see `.pixi/envs/py/lib/python3.11` mixed up with `/opt/ros/humble/lib/python3.10`: <details> <summary>Console Logs</summary> ``` $ pixi run py-test ✨ Pixi task (py-build in py): pixi run -e py py-build-common ✨ Pixi task (rerun-build in py): cargo build --package rerun-cli --no-default-features --features map_view,nasm,native_viewer Finished `dev` profile [optimized + debuginfo] target(s) in 0.34s ✨ Pixi task (py-build-common in py): PIP_REQUIRE_VIRTUALENV=0 RERUN_ALLOW_MISSING_BIN=1 maturin develop --manifest-path rerun_py/Cargo.toml --extras=tests 🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings with abi3 support for Python ≥ 3.8 🐍 Not using a specific python interpreter 📡 Using build options locked, config from pyproject.toml Ignoring rerun-notebook: markers 'extra == "notebook"' don't match your environment Requirement already satisfied: attrs>=23.1.0 in ./.pixi/envs/py/lib/python3.11/site-packages (24.2.0) Requirement already satisfied: numpy<2,>=1.23 in ./.pixi/envs/py/lib/python3.11/site-packages (1.26.4) Requirement already satisfied: pillow>=8.0.0 in ./.pixi/envs/py/lib/python3.11/site-packages (10.0.0) Requirement already satisfied: pyarrow>=14.0.2 in ./.pixi/envs/py/lib/python3.11/site-packages (18.0.0) Requirement already satisfied: typing-extensions>=4.5 in ./.pixi/envs/py/lib/python3.11/site-packages (4.12.2) Requirement already satisfied: pytest==7.1.2 in ./.pixi/envs/py/lib/python3.11/site-packages (7.1.2) Requirement already satisfied: iniconfig in ./.pixi/envs/py/lib/python3.11/site-packages (from pytest==7.1.2) (2.0.0) Requirement already satisfied: packaging in ./.pixi/envs/py/lib/python3.11/site-packages (from pytest==7.1.2) (24.1) Requirement already satisfied: pluggy<2.0,>=0.12 in ./.pixi/envs/py/lib/python3.11/site-packages (from pytest==7.1.2) (1.5.0) Requirement already satisfied: py>=1.8.2 in ./.pixi/envs/py/lib/python3.11/site-packages (from pytest==7.1.2) (1.11.0) Requirement already satisfied: tomli>=1.0.0 in ./.pixi/envs/py/lib/python3.11/site-packages (from pytest==7.1.2) (2.0.2) Finished `dev` profile [optimized + debuginfo] target(s) in 0.24s 📦 Built wheel for abi3 Python ≥ 3.8 to /tmp/.tmpBFVm0m/rerun_sdk-0.21.0a1+dev-cp38-abi3-linux_x86_64.whl ✏️ Setting installed package as editable 🛠 Installed rerun-sdk-0.21.0a1+dev ✨ Pixi task (py-test in py): python -m pytest -vv rerun_py/tests/unit ======================================================================= test session starts ======================================================================= platform linux -- Python 3.11.10, pytest-7.1.2, pluggy-1.5.0 -- /home/abhishek/Code/rerun/.pixi/envs/py/bin/python cachedir: .pytest_cache benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000) rootdir: /home/abhishek/Code/rerun/rerun_py, configfile: pyproject.toml plugins: ament-xmllint-0.12.11, ament-lint-0.12.11, ament-copyright-0.12.11, launch-pytest-1.0.6, launch-testing-ros-0.19.7, ament-flake8-0.12.11, ament-pep257-0.12.11, launch-testing-1.0.6, benchmark-4.0.0, anyio-4.6.2.post1 collected 0 items / 1 error ============================================================================= ERRORS ============================================================================== _____________________________________________________________ ERROR collecting tests/unit/__init__.py _____________________________________________________________ .pixi/envs/py/lib/python3.11/site-packages/pluggy/_hooks.py:513: in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) .pixi/envs/py/lib/python3.11/site-packages/pluggy/_manager.py:120: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) .pixi/envs/py/lib/python3.11/site-packages/_pytest/python.py:206: in pytest_collect_file module: Module = ihook.pytest_pycollect_makemodule( .pixi/envs/py/lib/python3.11/site-packages/_pytest/config/compat.py:67: in fixed_hook return hook(**kw) .pixi/envs/py/lib/python3.11/site-packages/pluggy/_hooks.py:513: in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) .pixi/envs/py/lib/python3.11/site-packages/pluggy/_manager.py:120: in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) /opt/ros/humble/lib/python3.10/site-packages/launch_testing/pytest/hooks.py:193: in pytest_pycollect_makemodule entrypoint = find_launch_test_entrypoint(path) /opt/ros/humble/lib/python3.10/site-packages/launch_testing/pytest/hooks.py:183: in find_launch_test_entrypoint module = import_path(path, root=None) .pixi/envs/py/lib/python3.11/site-packages/_pytest/pathlib.py:533: in import_path importlib.import_module(module_name) .pixi/envs/py/lib/python3.11/importlib/__init__.py:126: in import_module return _bootstrap._gcd_import(name[level:], package, level) <frozen importlib._bootstrap>:1204: in _gcd_import ??? <frozen importlib._bootstrap>:1176: in _find_and_load ??? <frozen importlib._bootstrap>:1147: in _find_and_load_unlocked ??? <frozen importlib._bootstrap>:690: in _load_unlocked ??? .pixi/envs/py/lib/python3.11/site-packages/_pytest/assertion/rewrite.py:168: in exec_module exec(co, module.__dict__) rerun_py/tests/unit/test_annotation_context.py:6: in <module> import rerun as rr rerun_py/rerun/__init__.py:36: in <module> sys.modules["rerun"] = __import__("rerun") rerun_py/rerun_sdk/rerun/__init__.py:28: in <module> from . import ( rerun_py/rerun_sdk/rerun/blueprint/__init__.py:7: in <module> from ..datatypes import ( # Re-export time range types for better discoverability. rerun_py/rerun_sdk/rerun/datatypes/__init__.py:5: in <module> from .angle import Angle, AngleArrayLike, AngleBatch, AngleLike rerun_py/rerun_sdk/rerun/datatypes/angle.py:12: in <module> import pyarrow as pa .pixi/envs/py/lib/python3.11/site-packages/pyarrow/__init__.py:65: in <module> import pyarrow.lib as _lib E ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by /home/abhishek/Code/rerun/.pixi/envs/py/lib/python3.11/site-packages/pyarrow/../../../libarrow.so.1800) ------------------------------------------------------------------------- Captured stderr ------------------------------------------------------------------------- DEV ENVIRONMENT DETECTED! Re-importing rerun from: /home/abhishek/Code/rerun/rerun_py/rerun_sdk ===================================================================== short test summary info ===================================================================== ERROR rerun_py/tests/unit/__init__.py - ImportError: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by /home/abhishek/Co... !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ======================================================================== 1 error in 0.20s ========================================================================= ``` </details> <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
grtlr
added a commit
that referenced
this pull request
Dec 9, 2024
### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * Part of #8299 ### What This adds a simple single line edit for position 2D. There is no `speed_fn` because I think in most applications UI coordinates are probably good unit (for example in graphs). https://github.com/user-attachments/assets/2fad00c4-8e68-40fe-a474-32fa5806814e <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. --> --------- Co-authored-by: Andreas Reich <andreas@rerun.io>
grtlr
added a commit
that referenced
this pull request
Dec 10, 2024
### Related * Closes #8278 <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> ### What Title. <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. --> --------- Co-authored-by: Antoine Beyeler <antoine@rerun.io>
grtlr
added a commit
that referenced
this pull request
Dec 10, 2024
Also wraps each manifest in a `<code>` tag for ✨. ### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * #8384. ### What Title. <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
grtlr
added a commit
that referenced
this pull request
Dec 11, 2024
### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * Closes #8277 * Closes #8327 * Closes #8237 ### What This fixes many problems around the state of the graph view. Turns out the scene rect alone is not sufficient to store all of the viewer state (who would have thought 😇). <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. --> --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>
grtlr
added a commit
that referenced
this pull request
Dec 11, 2024
### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * #8390 (partial revert) ### What We encountered some problems with this implementation. Discussion: https://rerunio.slack.com/archives/C04MTSM2U91/p1733921898485069 <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
Wumpf
pushed a commit
that referenced
this pull request
Dec 13, 2024
### Related <!-- Include links to any related issues/PRs in a bulleted list, for example: * Closes #1234 * Part of #1337 --> * Closes #8415 ### What Title. It looks like we never had a fallback provider for `NearClipPlane`. @Wumpf can you please confirm that this is correct? 🙏 <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was double-checking what happened with analytics when launching the rerun demo and I felt in the existing printout the command to run really just blended into the summary. I had to read it twice to realize it was there.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)