-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing screenshots of graph view archetypes #8371
Conversation
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fan of the new behaviour, but I'm a bit torn on the appropriate way to go about it.
At the very least, resizing the view should maintain the center point of the view (e.g. if the view is centred on a graph, resizing the view keeps the view centred on that graph).
I general, I also tend to prefer that resizing the view also adjust the scale factor to maintain the current "field of view". However our scaling is not the greatest, and it's cap to zoom level 1. So maybe we dont do that part.
Before implementing this, I looked at how other canvas-like applications (Figma Web, Affinity Designer 2) handle resizing and copied that because that's probably what most users expect. It think we can make case for both sides, but I wonder if we should stray to far from what others are doing? |
I've check our other views. All have the "keep centring" behaviour, but none do any zooming on resize. We should stick to that exact same behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related
GraphEdges
,GraphNodes
, andGraphView
archetypes #8277VisualBounds2D
to blueprint on any hover #8327What
This fixes many problems around the state of the graph view. Turns out the scene rect alone is not sufficient to store all of the viewer state (who would have thought 😇).