Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify zoom-and-pan area #8390

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Simplify zoom-and-pan area #8390

merged 4 commits into from
Dec 11, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Dec 10, 2024

  • Simplify the zoom-pan-view
  • Fix the zoom-pan-view eating the viewport highlight rectangle

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work feat-graph-view Everything related to the graph view labels Dec 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ d53818b https://rerun.io/viewer/pr/8390 +nightly +main

Note: This comment is updated whenever you push a commit.

grtlr
grtlr approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@grtlr grtlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤩

crates/store/re_chunk_store/src/writes.rs Outdated Show resolved Hide resolved
@grtlr grtlr mentioned this pull request Dec 10, 2024
Merged
@grtlr grtlr merged commit 91256d7 into main Dec 11, 2024
31 checks passed
@grtlr grtlr deleted the emilk/improve-graph-stuff branch December 11, 2024 10:40
grtlr added a commit that referenced this pull request Dec 11, 2024
@grtlr
Fix node selection not working on graph node text labels (#8394)
867ec9e 
### What

This fixes a bug where specifically, selecting nodes via text labels was
not working. We encountered this bug during our work on #8390.

### How to test

To test open the `+main` manifest in the web viewer (link in bot message
below), select the graph lattice example and try clicking on nodes.

<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->
grtlr added a commit that referenced this pull request Dec 11, 2024
@grtlr
Partial revert #8390: removal of Area in zoom_pan_area
edea981
@grtlr grtlr mentioned this pull request Dec 11, 2024
Merged
grtlr added a commit that referenced this pull request Dec 11, 2024
@grtlr
Partial revert #8390: removal of Area in zoom_pan_area (#8416)
388c8aa 
### Related

<!--
Include links to any related issues/PRs in a bulleted list, for example:
* Closes #1234
* Part of #1337 
-->

* #8390 (partial revert)

### What

We encountered some problems with this implementation.

Discussion:
https://rerunio.slack.com/archives/C04MTSM2U91/p1733921898485069

<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->
emilk added a commit that referenced this pull request Dec 13, 2024
@emilk
Revert "Partial revert #8390: removal of Area in zoom_pan_area (#…
a80b3bb 
…8416)"

This reverts commit 388c8aa.
@grtlr grtlr mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grtlr grtlr grtlr approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md feat-graph-view Everything related to the graph view ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @grtlr