Implement incremental graph layouts #8308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grtlr
added
ui
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
approved these changes
Dec 4, 2024
Comment on lines
+113
to
+125
| Self::Finished { layout, .. } => { | ||
| let mut provider = ForceLayoutProvider::new_with_previous(new_request, &layout); | ||
| let mut layout = provider.init(); | ||
| provider.tick(&mut layout); | ||
|
|
||
| Self::InProgress { layout, provider } | ||
| } | ||
| Self::InProgress { | ||
| layout, provider, .. | ||
| } if provider.request != new_request => { | ||
| let mut provider = ForceLayoutProvider::new_with_previous(new_request, &layout); | ||
| let mut layout = provider.init(); | ||
| provider.tick(&mut layout); |
There was a problem hiding this comment.
these two match arms look like they can be lumped together:
Suggested change
| Self::Finished { layout, .. } => { | |
| let mut provider = ForceLayoutProvider::new_with_previous(new_request, &layout); | |
| let mut layout = provider.init(); | |
| provider.tick(&mut layout); | |
| Self::InProgress { layout, provider } | |
| } | |
| Self::InProgress { | |
| layout, provider, .. | |
| } if provider.request != new_request => { | |
| let mut provider = ForceLayoutProvider::new_with_previous(new_request, &layout); | |
| let mut layout = provider.init(); | |
| provider.tick(&mut layout); | |
| Self::Finished { layout, .. } | Self::InProgress { | |
| layout, provider, .. | |
| } if provider.request != new_request => { | |
| let mut provider = ForceLayoutProvider::new_with_previous(new_request, &layout); | |
| let mut layout = provider.init(); | |
| provider.tick(&mut layout); |
There was a problem hiding this comment.
I don't think that's possible due to the if-guard on the Self::InProgress arm.
There was a problem hiding this comment.
oh ok. I didn't know there was such a restriction.
Co-authored-by: Antoine Beyeler <49431240+abey79@users.noreply.github.com>
### Related * split out of #8234 ### What * use `ViewProperty` util construct some more * route individual property ui via `view_property_component_ui_custom` making it easier to draw custom ui for specific view properties while still having all tooltip & extra menus be the same
### What Fixes CI problems (https://github.com/rerun-io/rerun/actions/runs/12160549310/job/33913118372?pr=8313): ``` error[vulnerability]: Borsh serialization of HashMap is non-canonical ┌─ /home/runner/work/rerun/rerun/Cargo.lock:225:1 │ 225 │ hashbrown 0.15.0 registry+https://github.com/rust-lang/crates.io-index │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected │ ├ ID: RUSTSEC-2024-0402 ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0402 ├ The borsh serialization of the HashMap did not follow the borsh specification. It potentially produced non-canonical encodings dependent on insertion order. It also did not perform canonicty checks on decoding. This can result in consensus splits and cause equivalent objects to be considered distinct. This was patched in 0.15.1. ``` <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
### What After refactoring, _implicit_ nodes were visualized using regular `text_color` and where therefore no possible to differentiate from regular nodes. This PR fixes that. <img width="44" alt="image" src="https://github.com/user-attachments/assets/d1c32758-2154-4842-ab18-9be9b899c6d0"> The node on the bottom (darker gray) is implicit. <!-- Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, and our `git log`. If you have noticed any breaking changes, include them in the migration guide. We track various metrics at <https://build.rerun.io>. For maintainers: * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
We made the decision to carry over layout information between timestamps as it leads to a much nicer user experience. This PR implements that feature.
@abey79 Some of the logic in
provider.rshas to change again for blueprint support. I plan to do a cleanup pass in #8299.Screen.Recording.2024-12-04.at.09.44.00.mov