-
Notifications
You must be signed in to change notification settings - Fork 366
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MVP Blueprint APIs for layout and contents (#5408)
### What - Remove the old experimental blueprint flags from init - Introduces a new file `rerun_py/rerun_sdk/rerun/blueprint/api.py` which defines the beginning of an API surface - Create declarative-object-helpers for Viewport, Container, and SpaceView - These follow a pattern of recursively logging their content + themselves to a stream. - Introduce a new mechanism for optionally sending a blueprint on connect. This is sent inline on the sink before setting up the reset of the stream. - On the rust side we just take an optional `Vec<LogMsg>` - On the python side we use the MemorySink as a convenient mechanism of logging to the stream APIs and then re-extracting the data as messages. - Fix some assorted errors: - space_views should have been optional - stream.log apparently never worked ### Known issues: - There are several fields that we still need to plumb through. - The old blueprint example is broken. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5408/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5408/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5408/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5408) - [Docs preview](https://rerun.io/preview/9a4aff23ac532eb7bf08cf6aa6cf3d9ce6d8bfd9/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/9a4aff23ac532eb7bf08cf6aa6cf3d9ce6d8bfd9/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
- Loading branch information
Showing
17 changed files
with
560 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 37 additions & 25 deletions
62
crates/re_viewport/src/blueprint/archetypes/viewport_blueprint.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
rerun_cpp/src/rerun/blueprint/archetypes/viewport_blueprint.cpp
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
14 changes: 9 additions & 5 deletions
14
rerun_cpp/src/rerun/blueprint/archetypes/viewport_blueprint.hpp
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.