MVP Blueprint APIs for layout and contents #5408
Conversation
jleibs
changed the base branch from
main
to
andreas/serializable-spaceviewblueprint
jleibs
force-pushed
the
jleibs/blueprint_test
branch
3 times, most recently
from
680ac6f to
50d6106
Compare
jleibs
force-pushed
the
jleibs/blueprint_test
branch
from
50d6106 to
6664cf3
Compare
jleibs
changed the title
jleibs
added
🟦 blueprint
| @@ -218,6 +218,9 @@ def log_components( | |||
| if None, use the global default from `rerun.strict_mode()` | |||
|
|
|||
| """ | |||
| # Convert to a native recording | |||
| recording = RecordingStream.to_native(recording) | |||
There was a problem hiding this comment.
This was just an error before on this API. Apparently we don't use stream-overrides in any of our other examples.
There was a problem hiding this comment.
Both Container and SpaceView are veeery close to just being extension methods to ContainerBlueprint and SpaceViewBlueprint. I think that would be still worth considering as it means we have less types around and things will look less magic overall, making it a little bit more transparent what's going on - it's arguably both an advantage and disadvantage that this would expose the archetype's properties directly.
The derived Spatial2D/3D/Vertical/Horizontal etc. classes can still work the exact same way then I reckon
Love how easy and small api.py is. I'd recommend getting this in with above higher level comment(s) unresolved so we can all get our hands at the actual API asap :)
| # Handle the cases for SpaceViewContentsLike | ||
| if isinstance(self.contents, str): | ||
| # str | ||
| contents = SpaceViewContents(query=self.contents) | ||
| elif isinstance(self.contents, Sequence) and len(self.contents) > 0 and isinstance(self.contents[0], str): | ||
| # list[str] | ||
| contents = SpaceViewContents(query="\n".join(self.contents)) | ||
| elif isinstance(self.contents, SpaceViewContents): | ||
| # SpaceViewContents | ||
| contents = self.contents | ||
| else: | ||
| # Anything else we let SpaceViewContents handle | ||
| contents = SpaceViewContents(query=self.contents) # type: ignore[arg-type] |
There was a problem hiding this comment.
it would be nicer if these were handled by SpaceViewContents in such a way that passing any of them to SpaceViewContents gives you a new usable SpaceViewContents
That way we can also unit test that separately
There was a problem hiding this comment.
Uggh, this is a bit annoying. Leaving a TODO.
Size changes
|
What
rerun_py/rerun_sdk/rerun/blueprint/api.pywhich defines the beginning of an API surfaceVec<LogMsg>Known issues:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io