-
Notifications
You must be signed in to change notification settings - Fork 366
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for visible time range to the dataframe view (#6869)
### What - Part of #4466 - Soft-blocked by #6878 This adds support for visible time range to the dataframe. For now (likely to be iterated on soon), this mode is enabled when _any_ of the view entities have visible time range enabled (see note below). In that mode, rows are indexed by (entity, time, row_id) and can be sorted with either of the first two (asc or desc) using two new view properties. The dataframe feature is—and remains—behind an opt-in feature flag. #### Note on the current latest at vs. range switch Currently A single view entity with visible time range force the entire view into this mode. In particular, it force-opt-in *all* view entities to visible time range, setting it to `Rel(0)-Rel(0)` when not explicitly set. (It's as if the view's default visible time range switched to `Rel(0)-Rel(0)` although that's not how it's implemented.) This implicit behaviour is not ideal, and we probably should design a better way to go about it, see #4466. <img width="2004" alt="image" src="https://github.com/user-attachments/assets/025694b7-9029-4ab8-bdf4-6d9954a6792c"> ### Checklist * [x] update view help text * [x] split in multiple files * [x] clean Chunk stuff * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6869?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6869?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6869) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
- Loading branch information
Showing
42 changed files
with
1,899 additions
and
181 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
crates/store/re_types/definitions/rerun/blueprint/archetypes/range_table_order.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
include "arrow/attributes.fbs"; | ||
include "python/attributes.fbs"; | ||
include "rust/attributes.fbs"; | ||
|
||
include "rerun/attributes.fbs"; | ||
|
||
namespace rerun.blueprint.archetypes; | ||
|
||
|
||
/// Configuration for the sorting of the rows of a time range table. | ||
table RangeTableOrder ( | ||
"attr.rerun.scope": "blueprint", | ||
"attr.rust.derive": "Copy", | ||
"attr.rust.generate_field_info" | ||
) { | ||
// --- Optional --- | ||
|
||
/// The primary sort key. | ||
sort_key: rerun.blueprint.components.SortKey ("attr.rerun.component_optional", nullable, order: 1000); | ||
|
||
/// The sort order. | ||
sort_order: rerun.blueprint.components.SortOrder ("attr.rerun.component_optional", nullable, order: 2000); | ||
} |
20 changes: 20 additions & 0 deletions
20
crates/store/re_types/definitions/rerun/blueprint/components/sort_key.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
include "arrow/attributes.fbs"; | ||
include "python/attributes.fbs"; | ||
include "rust/attributes.fbs"; | ||
|
||
include "rerun/datatypes.fbs"; | ||
include "rerun/attributes.fbs"; | ||
|
||
namespace rerun.blueprint.components; | ||
|
||
|
||
/// Primary element by which to group by in a temporal data table. | ||
enum SortKey: byte ( | ||
"attr.rerun.scope": "blueprint" | ||
) { | ||
/// Group by entity. | ||
Entity (default), | ||
|
||
/// Group by instance. | ||
Time, | ||
} |
20 changes: 20 additions & 0 deletions
20
crates/store/re_types/definitions/rerun/blueprint/components/sort_order.fbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
include "arrow/attributes.fbs"; | ||
include "python/attributes.fbs"; | ||
include "rust/attributes.fbs"; | ||
|
||
include "rerun/datatypes.fbs"; | ||
include "rerun/attributes.fbs"; | ||
|
||
namespace rerun.blueprint.components; | ||
|
||
|
||
/// Sort order for data table. | ||
enum SortOrder: byte ( | ||
"attr.rerun.scope": "blueprint" | ||
) { | ||
/// Ascending | ||
Ascending (default), | ||
|
||
/// Descending | ||
Descending, | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
201 changes: 201 additions & 0 deletions
201
crates/store/re_types/src/blueprint/archetypes/range_table_order.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 2 additions & 0 deletions
2
crates/store/re_types/src/blueprint/components/.gitattributes
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.