Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for visible time range to the dataframe view #6869

Merged
merged 18 commits into from
Jul 15, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 12, 2024

What

This adds support for visible time range to the dataframe. For now (likely to be iterated on soon), this mode is enabled when any of the view entities have visible time range enabled (see note below). In that mode, rows are indexed by (entity, time, row_id) and can be sorted with either of the first two (asc or desc) using two new view properties.

The dataframe feature is—and remains—behind an opt-in feature flag.

Note on the current latest at vs. range switch

Currently A single view entity with visible time range force the entire view into this mode. In particular, it force-opt-in all view entities to visible time range, setting it to Rel(0)-Rel(0) when not explicitly set. (It's as if the view's default visible time range switched to Rel(0)-Rel(0) although that's not how it's implemented.)

This implicit behaviour is not ideal, and we probably should design a better way to go about it, see #4466.

image

Checklist

  •  update view help text
  • split in multiple files
  • clean Chunk stuff
  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 force-pushed the antoine/dataframe-time-range branch from c088a37 to 01615d7 Compare July 12, 2024 15:56
@abey79 abey79 added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself enhancement New feature or request include in changelog labels Jul 12, 2024
@abey79 abey79 changed the title (WIP) Temporal dataframe table Add support for visible time range to the dataframe view Jul 14, 2024
@abey79 abey79 mentioned this pull request Jul 14, 2024
37 tasks
@abey79 abey79 marked this pull request as ready for review July 15, 2024 07:58
@teh-cmc teh-cmc self-assigned this Jul 15, 2024
Comment on lines +99 to +104
let results = ctx.recording().query_caches().latest_at(
ctx.recording_store(),
&latest_at_query,
&instance.entity_path,
[*component_name],
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could port this one to the chunk APIs next

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, i ment to do it. I'll do a follow-up PR.

@abey79 abey79 merged commit b580da4 into main Jul 15, 2024
40 checks passed
@abey79 abey79 deleted the antoine/dataframe-time-range branch July 15, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants