-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for visible time range to the dataframe view #6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abey79
force-pushed
the
antoine/dataframe-time-range
branch
from
July 12, 2024 15:56
c088a37
to
01615d7
Compare
abey79
added
ui
concerns graphical user interface
📺 re_viewer
affects re_viewer itself
enhancement
New feature or request
include in changelog
labels
Jul 12, 2024
abey79
changed the title
(WIP) Temporal dataframe table
Add support for visible time range to the dataframe view
Jul 14, 2024
teh-cmc
approved these changes
Jul 15, 2024
crates/store/re_types/definitions/rerun/blueprint/archetypes/range_table_settings.fbs
Outdated
Show resolved
Hide resolved
crates/store/re_types/definitions/rerun/blueprint/archetypes/range_table_settings.fbs
Outdated
Show resolved
Hide resolved
crates/store/re_types/definitions/rerun/blueprint/components/table_group_by.fbs
Outdated
Show resolved
Hide resolved
Comment on lines
+99
to
+104
let results = ctx.recording().query_caches().latest_at( | ||
ctx.recording_store(), | ||
&latest_at_query, | ||
&instance.entity_path, | ||
[*component_name], | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we could port this one to the chunk APIs next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, i ment to do it. I'll do a follow-up PR.
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
include in changelog
📺 re_viewer
affects re_viewer itself
ui
concerns graphical user interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds support for visible time range to the dataframe. For now (likely to be iterated on soon), this mode is enabled when any of the view entities have visible time range enabled (see note below). In that mode, rows are indexed by (entity, time, row_id) and can be sorted with either of the first two (asc or desc) using two new view properties.
The dataframe feature is—and remains—behind an opt-in feature flag.
Note on the current latest at vs. range switch
Currently A single view entity with visible time range force the entire view into this mode. In particular, it force-opt-in all view entities to visible time range, setting it to
Rel(0)-Rel(0)
when not explicitly set. (It's as if the view's default visible time range switched toRel(0)-Rel(0)
although that's not how it's implemented.)This implicit behaviour is not ideal, and we probably should design a better way to go about it, see #4466.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.