-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
objectron
Python example is broken
#2557
Labels
🪳 bug
Something isn't working
examples
Issues relating to the Rerun examples
🐍 Python API
Python logging API
Comments
emilk
added
🪳 bug
Something isn't working
🐍 Python API
Python logging API
examples
Issues relating to the Rerun examples
labels
Jun 28, 2023
It used to work. Maybe it broke because we don't freeze pip package versions? |
3 tasks
emilk
pushed a commit
that referenced
this issue
Jun 28, 2023
### What The change from List -> list was introduced as part of: - #2361 However it seems to break objectron on python3.8: - #2557 Reverting just this bit causes it to work for me, though I don't fully understand the intention or ramifications. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested https://demo.rerun.io/pr/2559 (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2559 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/4073c08/docs Examples preview: https://rerun.io/preview/4073c08/examples <!-- pr-link-docs:end -->
Closed by #2559 |
emilk
pushed a commit
that referenced
this issue
Jun 29, 2023
### What The change from List -> list was introduced as part of: - #2361 However it seems to break objectron on python3.8: - #2557 Reverting just this bit causes it to work for me, though I don't fully understand the intention or ramifications. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested https://demo.rerun.io/pr/2559 (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2559 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/4073c08/docs Examples preview: https://rerun.io/preview/4073c08/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🪳 bug
Something isn't working
examples
Issues relating to the Rerun examples
🐍 Python API
Python logging API
The text was updated successfully, but these errors were encountered: