Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze pip package versions #2439

Closed
emilk opened this issue Jun 15, 2023 · 5 comments
Closed

Freeze pip package versions #2439

emilk opened this issue Jun 15, 2023 · 5 comments
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🐑🐑 duplicate This issue or pull request already exists examples Issues relating to the Rerun examples 🐍 Python API Python logging API

Comments

@emilk
Copy link
Member

emilk commented Jun 15, 2023

We have a bunch of requirements.txt files which specify packages without version constraints, e.g:

numpy
pillow
requests>=2.31,<3
rerun-sdk
timm==0.6.11
torch>=1.13.0
transformers

We should probably make sure that every dependency is either specified with == or with >=X,<Y.

A lint could check all requirements*.txt files and make sure each line contains either ==, or >= and <

@emilk emilk added 🐍 Python API Python logging API 🧑‍💻 dev experience developer experience (excluding CI) examples Issues relating to the Rerun examples labels Jun 15, 2023
@abey79
Copy link
Member

abey79 commented Jun 15, 2023

This might create other issues, for example breaking on newer versions of python because the pinned version is wasn't then compatible. I believe the right way to go about this is:

  • use a package management tool that allows for lock files (poetry, hatch, etc.—whichever plays the nicest with maturin)
  • be more systematic with testing examples on all supported python version (with e.g. tox or nox)

@abey79
Copy link
Member

abey79 commented Jun 15, 2023

Side note: a tool like poetry would be really helpful to manage multiple dev environment to easily switch from 3.8 to 3.11, etc.

@emilk
Copy link
Member Author

emilk commented Jun 15, 2023

Let's punt on this until we have a full matrix CI test, testing all Python versions on all platforms under all star signs

@emilk
Copy link
Member Author

emilk commented Jan 11, 2024

Relevant for the upcoming numpy 2.0 release: https://pythonspeed.com/articles/numpy-2/

@emilk
Copy link
Member Author

emilk commented Apr 10, 2024

@emilk emilk closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@emilk emilk added the 🐑🐑 duplicate This issue or pull request already exists label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🐑🐑 duplicate This issue or pull request already exists examples Issues relating to the Rerun examples 🐍 Python API Python logging API
Projects
None yet
Development

No branches or pull requests

2 participants