Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full support for Transform3D archetype in Python #2643

Closed
6 tasks done
teh-cmc opened this issue Jul 10, 2023 · 1 comment · Fixed by #2770
Closed
6 tasks done

Full support for Transform3D archetype in Python #2643

teh-cmc opened this issue Jul 10, 2023 · 1 comment · Fixed by #2770
Assignees
@teh-cmc @jleibs @abey79
Labels
codegen/idl 🐍 Python API Python logging API

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jul 10, 2023 •
edited
Loading

  • Code is generated successfully
  • There's a unit test in place making sure that all possible constructors work now and tomorrow
  • The archetype has been backported to the existing SDK
    • log_transform still works
    • log_any(rr.Transform3D) works as well
  • test_api has been updated to make use of both log_transform and log_any based on a flag

Keep track of progress in:
@teh-cmc teh-cmc added 🐍 Python API Python logging API codegen/idl labels Jul 10, 2023
This was referenced Jul 10, 2023
Closed
Merged
@teh-cmc
Copy link
Member Author

teh-cmc commented Jul 21, 2023

Only thing left to do here is to update test_api, I'll do a PR in a moment.

@teh-cmc teh-cmc self-assigned this Jul 21, 2023
@teh-cmc teh-cmc mentioned this issue Jul 21, 2023
Merged
3 tasks
Wumpf pushed a commit that referenced this issue Jul 21, 2023
@teh-cmc
Update python's test_api to use new Transform3D APIs (#2770)
ccd0481 
This PR updates `test_api` to use the new `Transform3D` APIs, like we
did for `Points2D`.

Since the viewer hasn't yet been updated to the new transform types, and
the two aren't binary compatible, you won't see the result in the
viewer; but one can dump the datastore state to see that it indeed
works:

```
$ python tests/python/test_api/main.py --test transform_test
```

![image](https://github.com/rerun-io/rerun/assets/2910679/83c3a080-5451-418c-880d-fe55761f7bf7)

```
$ python tests/python/test_api/main.py --experimental-api --test transform_test
```

![image](https://github.com/rerun-io/rerun/assets/2910679/4426d284-9aff-43d8-b6da-c01fa59434d4)


Closes #2643

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2770) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2770)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Ffinish_transform_py/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Ffinish_transform_py/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

@jleibs jleibs

@abey79 abey79

Labels
codegen/idl 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update python's test_api to use new Transform3D APIs rerun-io/rerun
3 participants
@teh-cmc @jleibs @abey79