Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python's test_api to use new Transform3D APIs #2770

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Update python's test_api to use new Transform3D APIs #2770

merged 2 commits into from
Jul 21, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 21, 2023 •
edited
Loading

This PR updates test_api to use the new Transform3D APIs, like we did for Points2D.

Since the viewer hasn't yet been updated to the new transform types, and the two aren't binary compatible, you won't see the result in the viewer; but one can dump the datastore state to see that it indeed works:

$ python tests/python/test_api/main.py --test transform_test

image

$ python tests/python/test_api/main.py --experimental-api --test transform_test

image

Closes #2643

What

Checklist

@teh-cmc teh-cmc added 🐍 Python API Python logging API codegen/idl labels Jul 21, 2023
@Wumpf Wumpf self-requested a review July 21, 2023 08:18
@Wumpf Wumpf merged commit ccd0481 into main Jul 21, 2023
@Wumpf Wumpf deleted the cmc/finish_transform_py branch July 21, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
codegen/idl 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full support for Transform3D archetype in Python
2 participants
@teh-cmc @Wumpf