Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Improve Figma → Implementation accuracy #2670

Open
17 of 25 tasks
martenbjork opened this issue Jul 11, 2023 · 4 comments
Open
17 of 25 tasks

Tracking issue: Improve Figma → Implementation accuracy #2670

martenbjork opened this issue Jul 11, 2023 · 4 comments
Assignees
Labels
🪳 bug Something isn't working enhancement New feature or request 🎄 tracking issue issue that tracks a bunch of subissues ui concerns graphical user interface

Comments

@martenbjork
Copy link
Contributor

martenbjork commented Jul 11, 2023

The implementation is currently quite far off from the designs in Figma. Getting the implementation closer to Figma will make the product look better, and help us better gauge where the design is missing. 🚀

Tasks

Blueprint tree overhaul (to be pooled with new design)

Remove expansion animation effect:

From #2780:

Deferred to future, bigger, encompassing redesigns:

@martenbjork martenbjork added 🪳 bug Something isn't working enhancement New feature or request labels Jul 11, 2023
@martenbjork martenbjork self-assigned this Jul 11, 2023
@Wumpf Wumpf added ui concerns graphical user interface 🎄 tracking issue issue that tracks a bunch of subissues labels Jul 18, 2023
@abey79 abey79 self-assigned this Jul 24, 2023
@jleibs
Copy link
Member

jleibs commented Jul 24, 2023

If any of these are too difficult or require significant upstream changes to egui, then potentially push changes back into figma.

@martenbjork
Copy link
Contributor Author

Agreed! Let's find a cost-benefit middle ground if needed.

@abey79
Copy link
Member

abey79 commented Jul 24, 2023

Demo site as of just prior to starting on these issues: https://demo.rerun.io/pr/2781/examples/structure_from_motion/

Handy to have around for comparison (e.g. #2796 made #2728 somewhat worse).

@abey79
Copy link
Member

abey79 commented Jul 26, 2023

We just had a technical/tactical discussion with @Wumpf on many of these issues:

  • In several cases, we need to create custom widget wrappers. This could be done using this pattern: ReUi(ui).checkbox(...), enabling relatively easy migration of the existing code. At first sight, these widgets are involved:
  • It would be great to add per-widget-type overrides to egui's visuals (implemented as Option). TBD with @emilk.
  • Short term, I'll focus on easy (for real...) issues and start rolling in custom widgets to address the more complicated ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working enhancement New feature or request 🎄 tracking issue issue that tracks a bunch of subissues ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

4 participants