New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "selected" state when hovering a blueprint item #2728

Closed

Tracked by

,

...

martenbjork opened this issue Jul 18, 2023 · 0 comments · Fixed by #2824

Closed

Tracked by

,

...

Fix "selected" state when hovering a blueprint item #2728

martenbjork opened this issue Jul 18, 2023 · 0 comments · Fixed by #2824

Labels

ui

Contributor

martenbjork commented Jul 18, 2023 •

edited

Loading

This is what a selected Blueprint item looks like:

When hovered, the item changes to this:

It's a strange state, because it's not clear what is hovered vs selected.

👉 For now, I recommend changing the grey color in the hover state to blue, so that the entire elements looks selected, even when hovered.

martenbjork mentioned this issue

Tracking issue: Improve Figma → Implementation accuracy #2670

Open

25 tasks

Wumpf added the ui label

jleibs mentioned this issue

Assorted Design Improvements #2780

Closed

16 tasks

abey79 mentioned this issue

Fix selection highlighting in blueprint tree view #2824

Merged

3 tasks

Wumpf closed this as completed in #2824

Wumpf pushed a commit that referenced this issue


          Fix selection highlighting in blueprint tree view (#2824)

c3487e2

### What

Before:

<img width="170" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/3e2c9525-88d9-450d-8f58-b84f13a3ba4d">

After:

<img width="264" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/93437750-ff7b-42e5-8332-507cb1300e5c">

This PR also reverts #2796 (fixes #2828).


#### Changes
- Blue area is properly drawn
- Size of the hover/selection effect is fixed (after being broken in
#2796)

Fixes #2728

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2824) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2824)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fblueprint_tree_selection_2728/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fblueprint_tree_selection_2728/examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment