Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to deselect #2709

Closed
Tracked by #2670
, #2780
...
roym899 opened this issue Jul 17, 2023 · 6 comments · Fixed by #4831 or #5103
Closed
Tracked by #2670
, #2780
...

No way to deselect #2709

roym899 opened this issue Jul 17, 2023 · 6 comments · Fixed by #4831 or #5103
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself ui concerns graphical user interface

Comments

@roym899
Copy link
Collaborator

roym899 commented Jul 17, 2023 •
edited
Loading

Describe the annoyance
Once an entity is selected, I couldn't figure out a way to deselect it, other than selecting another entity. So to have nothing highlighted I have to select an entity that isn't in the view or delete the entity that is currently selected.

Generally this feels a bit unintuitive. I think most other programs would, for example, deselect when clicking into any white space.
@roym899 roym899 added 👀 needs triage This issue needs to be triaged by the Rerun team 😤 annoying Something in the UI / SDK is annoying to use labels Jul 17, 2023
@roym899 roym899 changed the title No way to deselect all No way to deselect Jul 17, 2023
@roym899
Copy link
Collaborator Author

roym899 commented Jul 17, 2023 •
edited
Loading

Seems like this mostly applies to the 2D cases, because in 3D clicking into empty 3D space does deselect. Still, deselecting when clicking any white space of the UI seems reasonable as well.

@Wumpf Wumpf added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 18, 2023
@jleibs jleibs mentioned this issue Jul 21, 2023
Closed
16 tasks
@abey79 abey79 mentioned this issue Jul 24, 2023
Open
25 tasks
@abey79
Copy link
Member

abey79 commented Aug 7, 2023

Clicking in left panel's empty space should deselect

@abey79
Copy link
Member

abey79 commented Aug 7, 2023

Also, command-clicking on the item in the left panel deselects it.

@roym899
Copy link
Collaborator Author

roym899 commented Aug 17, 2023 •
edited
Loading

On the command clicking: this actually also works for entities inside the views, so this works well, once you know about it. However, it does not work for the title of the views. I would expect selection / deselection of the title to behave similar to the title in the left panel. Especially since they have a very similar visual once they are selected.

@abey79 abey79 mentioned this issue Aug 28, 2023
Open
30 tasks
@abey79 abey79 mentioned this issue Jan 16, 2024
Merged
4 tasks
abey79 added a commit that referenced this issue Jan 16, 2024
@abey79
Clear selection when clicking blank space in the Blueprint View (#4831)
fcc1e51 
### What

As the title says.

- Fixes #2709

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4831/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4831/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4831/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4831)
- [Docs
preview](https://rerun.io/preview/7c58c5ed42c20134bf28d110d28a313f3d378be8/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7c58c5ed42c20134bf28d110d28a313f3d378be8/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@roym899
Copy link
Collaborator Author

roym899 commented Feb 7, 2024

Reopening since clicking in empty space in 3D view doesn't deselect anymore.

Could we add deselect when clicking in the empty space right of the rerun.io text?

@roym899 roym899 reopened this Feb 7, 2024
@emilk
Copy link
Member

emilk commented Feb 7, 2024 •
edited
Loading

I'll can add so hitting escape deselects. That makes sense imho:

@emilk emilk mentioned this issue Feb 7, 2024
Merged
5 tasks
teh-cmc pushed a commit that referenced this issue Feb 7, 2024
@emilk
Click escape to deselect (#5103)
16c8737 
* Closes #4946
* Closes #2709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
4 participants
@emilk @Wumpf @roym899 @abey79