Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples should not manually reproject things across 3D<>2D views #3412

Closed
teh-cmc opened this issue Sep 22, 2023 · 1 comment · Fixed by #5617
Closed

Examples should not manually reproject things across 3D<>2D views #3412

teh-cmc opened this issue Sep 22, 2023 · 1 comment · Fixed by #5617
Labels
🟦 blueprint The data that defines our UI examples Issues relating to the Rerun examples
Milestone
0.15

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 22, 2023

Rerun does that!

But I'm guessing this is going to require blueprint queries possibly?

Can maybe tackle this at the same time as #3382 for ARKit.
@teh-cmc teh-cmc added the examples Issues relating to the Rerun examples label Sep 22, 2023
@Wumpf
Copy link
Member

Wumpf commented Sep 22, 2023

can't do this as part of #3382 since as you say it requires blueprint, otherwise you don't get to see boxes out of the box (heh)

@teh-cmc teh-cmc changed the title ARKit example should not manually reproject things across 3D<>2D views Examples should not manually reproject things across 3D<>2D views Sep 29, 2023
@teh-cmc teh-cmc added the 🟦 blueprint The data that defines our UI label Nov 28, 2023
@Wumpf Wumpf added this to the 0.15 milestone Mar 14, 2024
@Wumpf Wumpf mentioned this issue Mar 14, 2024
Merged
5 tasks
Wumpf added a commit that referenced this issue Mar 15, 2024
@Wumpf
Use blueprint in arkit_scenes demo, leveraging the viewer's ability t…
8fad2ca 
…o re-project 3D->2D (#5510)

### What

* Part of #3412

Removes a lot of code from the arkit demo and makes it look a little bit
nicer (beyond the 2d reprojections looking broken before!):
* two tabs for 2D, one with depth one with rgb
* named space views


![image](https://github.com/rerun-io/rerun/assets/1220815/eb7616da-ed6f-45bc-93ca-9453fdf5be17)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5510/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5510/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5510/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5510)
- [Docs
preview](https://rerun.io/preview/f2544987580d94f0d912eeaa224a98d46745f2a4/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/f2544987580d94f0d912eeaa224a98d46745f2a4/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79 added a commit that referenced this issue Mar 21, 2024
@abey79
Add blueprint to Objectron example
59dccf1 
- Fixes #3412
@abey79 abey79 mentioned this issue Mar 21, 2024
Merged
5 tasks
Wumpf pushed a commit that referenced this issue Mar 21, 2024
@abey79
Add blueprint to Objectron example (#5617)
49b2759 
### What

Add blueprint to Objectron example. I've removed all frame-based stuff
in favour of reprojecting world stuff into the 2D space view ✨

<img width="1658" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/7ddc9d90-f0b4-4e18-afe2-3e81fff76664">


- Fixes #3412

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5617/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5617/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5617/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5617)
- [Docs
preview](https://rerun.io/preview/59dccf1eeed6eb93c003d07c0091f22ce91fe8c5/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/59dccf1eeed6eb93c003d07c0091f22ce91fe8c5/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI examples Issues relating to the Rerun examples
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Add blueprint to Objectron example rerun-io/rerun
2 participants
@Wumpf @teh-cmc