-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use blueprint in arkit_scenes
demo, leveraging the viewer's ability to re-project 3D->2D
#5510
Conversation
…o re-project 3D->2D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
pixi.toml
Outdated
lint-taplo = "taplo fmt --check --diff" | ||
lint-typos = "typos" | ||
|
||
misc-fmt = "prettier --write '**/*.{yml,yaml,js,css,html}'" | ||
misc-fmt-check = "prettier --check '**/*.{yml,yaml,js,css,html}'" | ||
toml-fmt = "taplo fmt" | ||
ruff-fix = "ruff --fix --config rerun_py/pyproject.toml ." | ||
ruff-fix = "ruff format --config rerun_py/pyproject.toml ." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is ruff format
and ruff --fix
really the same thing? Was it renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this as well - does ruff --fix
work for you? Because on Windows this does nothing for me, so it's clearly not the same but it didn't get so much renamed as to the command failing -.-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe ruff --fix
fixes lints, i.e. NOT formatting.
So I would suggest keeping ruff-fix
and adding
ruff-format`, or combine them both under one command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah! adding both; can add a meta command later
done, but ofc this doesn't load blueprint yet, so it looks a bit worse than before (no projection there yet) |
Size changes
|
... sigh I should really look into getting python linting to be consistent on different platforms. Running locally I get all sort of errors but not those |
arkit_scenes
demo, leveraging the viewer's ability to re-project 3D->2D
What
Removes a lot of code from the arkit demo and makes it look a little bit nicer (beyond the 2d reprojections looking broken before!):
Checklist
main
build: app.rerun.ionightly
build: app.rerun.io