Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blueprint in arkit_scenes demo, leveraging the viewer's ability to re-project 3D->2D #5510

Merged
merged 8 commits into from
Mar 15, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 14, 2024

What

Removes a lot of code from the arkit demo and makes it look a little bit nicer (beyond the 2d reprojections looking broken before!):

  • two tabs for 2D, one with depth one with rgb
  • named space views

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added examples Issues relating to the Rerun examples include in changelog labels Mar 14, 2024
@emilk emilk self-requested a review March 14, 2024 15:51
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

examples/python/arkit_scenes/main.py Outdated Show resolved Hide resolved
pixi.toml Outdated
lint-taplo = "taplo fmt --check --diff"
lint-typos = "typos"

misc-fmt = "prettier --write '**/*.{yml,yaml,js,css,html}'"
misc-fmt-check = "prettier --check '**/*.{yml,yaml,js,css,html}'"
toml-fmt = "taplo fmt"
ruff-fix = "ruff --fix --config rerun_py/pyproject.toml ."
ruff-fix = "ruff format --config rerun_py/pyproject.toml ."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is ruff format and ruff --fix really the same thing? Was it renamed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by this as well - does ruff --fix work for you? Because on Windows this does nothing for me, so it's clearly not the same but it didn't get so much renamed as to the command failing -.-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ruff --fix fixes lints, i.e. NOT formatting.

So I would suggest keeping ruff-fix and adding ruff-format`, or combine them both under one command

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! adding both; can add a meta command later

@Wumpf
Copy link
Member Author

Wumpf commented Mar 14, 2024

I have tested the web demo (if applicable):

done, but ofc this doesn't load blueprint yet, so it looks a bit worse than before (no projection there yet)

Copy link

Size changes

Name main 5510/merge Change
arkit_scenes.rrd 40.34 MiB 39.43 MiB -2.26%

@Wumpf
Copy link
Member Author

Wumpf commented Mar 14, 2024

... sigh I should really look into getting python linting to be consistent on different platforms. Running locally I get all sort of errors but not those

@Wumpf Wumpf merged commit 8fad2ca into main Mar 15, 2024
10 of 20 checks passed
@Wumpf Wumpf deleted the andreas/arkitscenes-blueprint branch March 15, 2024 07:40
@emilk emilk changed the title Use blueprint in arkit_scenes demo, leveraging the viewer's ability to re-project 3D->2D Use blueprint in arkit_scenes demo, leveraging the viewer's ability to re-project 3D->2D Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants