Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer spawns new view as tabs when it shouldn't #3521

Closed
teh-cmc opened this issue Sep 28, 2023 · 1 comment · Fixed by #3524
Closed

Viewer spawns new view as tabs when it shouldn't #3521

teh-cmc opened this issue Sep 28, 2023 · 1 comment · Fixed by #3524
Assignees
@emilk
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Milestone
0.9 - Codegen, Ty...

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Sep 28, 2023

23-09-28_12.21.47.patched.mp4
@teh-cmc teh-cmc added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Sep 28, 2023
@emilk emilk self-assigned this Sep 28, 2023
@emilk
Copy link
Member

emilk commented Sep 28, 2023 •
edited
Loading

The problem is that the detection of user-interaction on the egui_tiles::Tree is not good enough. It compared the whole tree, but that will include detecting changes due to simplification, which we do in of adding a parent tab container to all our view tiles (simplification is really normalization).

This can be fixed by rerun-io/egui_tiles#28 but before I can deploy that I need to wait for a new release of egui_commonmark, because egui_tiles now depend on egui 0.23…

@emilk emilk mentioned this issue Sep 28, 2023
Merged
3 tasks
emilk added a commit that referenced this issue Sep 28, 2023
@emilk
Fix auto-layout of space views (#3524)
421b6a7 
### What
* Closes #3521

The problem was `auto_layout` being set to `false` too early.

This fix required a change to `egui_tiles`, so a patch-release of that
needs to be done before we publish rerun 0.9:

* rerun-io/egui_tiles#29

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [ ] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3524) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3524)
- [Docs
preview](https://rerun.io/preview/8abfdc1bbcd6ed36786600e59705f90b25017f7e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/8abfdc1bbcd6ed36786600e59705f90b25017f7e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

Successfully merging a pull request may close this issue.

Fix auto-layout of space views rerun-io/rerun
2 participants
@emilk @teh-cmc