Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto-layout of space views #3524

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Fix auto-layout of space views #3524

merged 5 commits into from
Sep 28, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 28, 2023 •
edited by github-actions bot
Loading

What

The problem was auto_layout being set to false too early.

This fix required a change to egui_tiles, so a patch-release of that needs to be done before we publish rerun 0.9:

Checklist

@Wumpf Wumpf self-requested a review September 28, 2023 17:05
@emilk emilk changed the title Emilk/fix auto layout Fix auto-layout of space views Sep 28, 2023
@emilk emilk added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 28, 2023
Wumpf
Wumpf approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
the callback is so much better than the tree comparison we did before. This together with the previous auto_layout instead of has_been_user_edite change makes this area much clearer!

crates/re_viewport/src/viewport.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 421b6a7 into main Sep 28, 2023
@emilk emilk deleted the emilk/fix-auto-layout branch September 28, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Viewer spawns new view as tabs when it shouldn't
2 participants
@emilk @Wumpf