-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breadcrumbs to the selection panel #4491
Comments
We're removing it because we're worried users will confuse it with the new Undo feature. After this PR, you can no longer go back in the selection history. But, we're planning on adding hierarchy breadcrumbs to the selections instead, which should hopefully be an even better way of understanding and navigating selections: * #4491
Upd:
|
### Related * Part of #4491 ### What Just moving some code around
### What We're removing it because we're worried users will confuse it with the new Undo feature. After this PR, you can no longer go back in the selection history. But, we're planning on adding hierarchy breadcrumbs to the selections instead, which should hopefully be an even better way of understanding and navigating selections: * #4491 ![image](https://github.com/user-attachments/assets/afb38bff-7e83-4dac-bb7f-cd27a8acca4d)
Still need to properly sync "projection" entities with the blueprint tree panel. The problem with projections include: I don't feel confident moving forward with this without a few more motivating examples of projections. |
This happens here: rerun/crates/viewer/re_blueprint_tree/src/blueprint_tree.rs Lines 390 to 406 in 76d4663
I'm probably biased as it was my idea, but I'm not deeply attached to it. If somebody has a more intuitive model for thinking about paths that are rooted above the origin, I'm totally open to it.
You can combine the snippet from above, with the logic to resolve an Following the pattern here: rerun/crates/viewer/re_selection_panel/src/selection_panel.rs Lines 261 to 266 in 76d4663
|
### Related * Part of #4491 ### What This adds "breadcrumbs" to each selection header in the selection panel, showing the ancestry of the selected thing. That should make it obvious if the selection belong to the blueprint tree panel, or the streams panel. ![image](https://github.com/user-attachments/assets/29c0b3de-3578-469f-8866-6d0b1dfa92b2) ![image](https://github.com/user-attachments/assets/17aa9dc0-6d89-413f-ba40-1b4c2c7dd63e) ![image](https://github.com/user-attachments/assets/8af19762-8ec3-48c8-9cd1-ef6d9459a6df) ![image](https://github.com/user-attachments/assets/dc1eaf3c-6aa8-4e4e-822e-c1e755a6f380) ### Future PR * Make projections appear the same in breadcrumbs as in the blueprint tree panel
Closed; next step in: |
The enclosing context of the selected item should be displayed as breadcrumbs to facilitate the navigation. This issue is about the design and implementation of this feature.
####New context from Dec '24
We are implementing undo, and want to get rid of the selection panel errors navigations ←→.
Despite the arrows being ambiguous UX element, it is being used to navigate via selected panels (especially when users click somewhere where they did not want to go, so they go 'back' to the previous view).
Assumption is that breadcrumbs will be a better navigation support for this as well as a more familiar ux pattern.
Design issues
Proposal based on Marten's sketches:
This will also allow to remove some of the elements in the selection panel as they will become redundant,
merge
parent
andin view
in blueprint, removein view
Implementation issues
cc @jleibs @emilk
The text was updated successfully, but these errors were encountered: