Add selection hierarchy breadcrumbs #8319

emilk · 2024-12-05T07:34:11Z

What

This adds "breadcrumbs" to each selection header in the selection panel, showing the ancestry of the selected thing.
That should make it obvious if the selection belong to the blueprint tree panel, or the streams panel.

Future PR

Make projections appear the same in breadcrumbs as in the blueprint tree panel

emilk · 2024-12-05T07:39:06Z

crates/viewer/re_data_ui/src/item_ui.rs

+        if entity_path.is_root() {
            ui.strong("/");


We used to show nothing if the root was selected

github-actions · 2024-12-05T07:39:44Z

Web viewer built successfully. If applicable, you should also test it:

I have tested the web viewer

Result	Commit	Link
✅	`53b5687`	https://rerun.io/viewer/pr/8319

^{Note: This comment is updated whenever you push a commit.}

emilk · 2024-12-05T07:44:45Z

crates/viewer/re_selection_panel/src/item_heading_with_breadcrumbs.rs

+
+                let relative = &entity_path.as_slice()[common_ancestor.len()..];
+
+                let is_projection = !entity_path.starts_with(&view.space_origin);


I still haven't figured out how to properly match the breadcrumbs with the blueprint tree panel for projections, since I don't have a good mental model for how projections are shown in the blueprint tree panel.

emilk · 2024-12-05T11:14:53Z

crates/viewer/re_viewer_context/src/data_result_node_or_path.rs

+use crate::{DataResultNode, DataResultTree};
+
+// TODO(@Wumpf): document this
+pub enum DataResultNodeOrPath<'a> {


@Wumpf you created this enum in #5342

I don't quite understand it, but I fear I may need to use of it in the next PR

nikolausWest · 2024-12-05T12:08:03Z

Not sure I understood why we removed the "In view" row (@gavrelina)

emilk · 2024-12-05T12:10:37Z

Not sure I understood why we removed the "In view" row (@gavrelina)

I guess for the same reason as we don't have a "In container" row for views/containers: we can now see that from the breadcrumbs 🤷

abey79

Thanks for that, very nice improvement!

abey79 · 2024-12-06T09:51:45Z

crates/viewer/re_data_ui/src/item_ui.rs

+        {
+            ui.spacing_mut().item_spacing.x = 2.0;

-        // Show one single icon up-front instead:
-        let instance_path = InstancePath::entity_all(entity_path.clone());
-        ui.add(instance_path_icon(&query.timeline(), db, &instance_path).as_image());
+            // The last part points to the selected entity, but that's ugly, so remove the highlight:
+            let visuals = ui.visuals_mut();
+            visuals.selection.bg_fill = egui::Color32::TRANSPARENT;
+            visuals.selection.stroke = visuals.widgets.inactive.fg_stroke;
+        }


does this scope serve a purpose?

Not really - it is just a logical grouping, and reducing the scope of variables, thus lessoning the mental overhead

crates/viewer/re_selection_panel/src/item_heading_with_breadcrumbs.rs

abey79 · 2024-12-06T10:03:53Z

crates/viewer/re_selection_panel/src/item_heading_with_breadcrumbs.rs

+            if instance.is_all() {
+                // Entity path. Exclude the last part from the breadcrumbs,
+                // as we will show it in full later on.
+                if let [all_but_last @ .., _] = entity_path.as_slice() {


woa TIL that syntax

crates/viewer/re_selection_panel/src/item_heading_with_breadcrumbs.rs

crates/viewer/re_selection_panel/src/item_title.rs

abey79 · 2024-12-06T10:17:52Z

crates/viewer/re_ui/data/icons/breadcrumbs_separator.png

really surprised this icon has odd values for both its dimensions. Shouldn't we aiming for good 2x ui scale factor?

Good question 🤔

It's 4x8 in figma

Exporting it with 2x…

…results in a PNG that is 11x19

FIGMA YOU HIGH

Oh, could be because of the thickness of the line:

I suggest we ignore this until we switch to .svg for all icons

crates/viewer/re_ui/src/list_item/list_item.rs

emilk added ui concerns graphical user interface include in changelog labels Dec 5, 2024

emilk commented Dec 5, 2024

View reviewed changes

emilk added 25 commits December 5, 2024 11:05

Always show an item, even if it is not found

dffaeb1

Refactor ItemTitle

ef61c69

Do not use Debug-formatting in user-facing strings

3fa7e02

Fix: make sure selected list items show up as such

8406c68

Implement selection heading contents manuallt

3436f82

Better titles on hover

7e8886a

Add breadcrumbs for containers and views

482d77b

Better file naming

18a6983

Breadcrumbs for component paths

f593c82

Add bread crumbs for component paths and instance paths from streams

a925b3f

Better parenting

5d79a96

Break up long functions

5e4c2d3

Fix warnings

509e058

More niceties

093f8f1

Dimmer breadcrumb colors

671906b

Move DataResultNodeOrPath into its own file

9276e85

MOAR CRUMBS

238d353

Fix origin-relative space view paths

ad865bf

Handle projections

c56d4b1

Cleanup

5c21dfa

Cleanup

a73f012

fix spacing and add a TODO

ddd3ff4

Remove icon from final item

6fd2d5a

Same separator icon for all crumbs

86c1ed8

Remove "in view" from data results (you can see it from the crumbs)

4744d65

Color tweaks

75bf9e6

emilk force-pushed the emilk/breadcrumbs branch from 8754d09 to 75bf9e6 Compare December 5, 2024 10:32

emilk added 4 commits December 5, 2024 11:44

Nicer tooltip

d53baa2

Better tooltips

79bcc4e

Make instance number clickable

8b2ec7c

Show icons sometimes

60fcb3e

emilk commented Dec 5, 2024

View reviewed changes

Fix extra indentation

c558169

emilk marked this pull request as ready for review December 5, 2024 12:05

emilk added 2 commits December 5, 2024 13:06

Change TODO

06ed243

Update Cargo.lock

9b4998c

Merge branch 'main' into emilk/breadcrumbs

16635df

Fix some TODOs

87964e3

emilk mentioned this pull request Dec 5, 2024

Add breadcrumbs to the selection panel #4491

Closed

2 tasks

emilk added 3 commits December 5, 2024 15:08

Add incstance number to selected instance path

73a2bfe

Fix ListItem jitter when we change selections

70b30da

Merge branch 'main' into emilk/breadcrumbs

3b0e7cc

abey79 approved these changes Dec 6, 2024

View reviewed changes

emilk added 4 commits December 6, 2024 13:44

Merge branch 'main' into emilk/breadcrumbs

ab4c9bb

Remove ItemTitle re-export

2b8ecb2

Better fix for selected listitem color

da81026

Add TODO

53b5687

emilk merged commit 003b00c into main Dec 6, 2024
31 checks passed

emilk deleted the emilk/breadcrumbs branch December 6, 2024 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add selection hierarchy breadcrumbs #8319

Add selection hierarchy breadcrumbs #8319

emilk commented Dec 5, 2024 •

edited

Loading

emilk Dec 5, 2024

github-actions bot commented Dec 5, 2024 •

edited

Loading

emilk Dec 5, 2024

emilk Dec 5, 2024 •

edited

Loading

nikolausWest commented Dec 5, 2024

emilk commented Dec 5, 2024

abey79 left a comment

abey79 Dec 6, 2024

emilk Dec 6, 2024

abey79 Dec 6, 2024

abey79 Dec 6, 2024

emilk Dec 6, 2024

emilk Dec 6, 2024

emilk Dec 6, 2024

emilk Dec 6, 2024


		let relative = &entity_path.as_slice()[common_ancestor.len()..];

		let is_projection = !entity_path.starts_with(&view.space_origin);

Add selection hierarchy breadcrumbs #8319

Add selection hierarchy breadcrumbs #8319

Conversation

emilk commented Dec 5, 2024 • edited Loading

Related

What

Future PR

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

emilk Dec 5, 2024 • edited Loading

Choose a reason for hiding this comment

nikolausWest commented Dec 5, 2024

emilk commented Dec 5, 2024

abey79 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilk commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

emilk Dec 5, 2024 •

edited

Loading