Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can't build rerun crate on their CI #5168

Closed
emilk opened this issue Feb 12, 2024 · 0 comments · Fixed by #5170
Closed

Users can't build rerun crate on their CI #5168

emilk opened this issue Feb 12, 2024 · 0 comments · Fixed by #5170
Labels
🪳 bug Something isn't working 🦀 Rust API Rust logging API 🚢 CI

Comments

@emilk
Copy link
Member

emilk commented Feb 12, 2024

image

We look for the env-var CI in our build.rs and if found, we assume we are on the Rerun CI.

crates/re_web_viewer_server/build.rs tried to build the web-viewer when on CI (for historic reasons…) which fails for users because they don't have the full crate folder structure required for that 🤦

Solutions

The best long-term solution is to not special-treat the CI at all.
If we want the web viewer built on CI, then we build it in a manual step (pixi run cargo run --locked -p re_build_web_viewer -- --release).

Another solution is to add a special RERUN_CI environment variable and use that instead of the generic CI that everyone uses.

@emilk emilk added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 🦀 Rust API Rust logging API 🚢 CI and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Feb 12, 2024
emilk added a commit that referenced this issue Feb 12, 2024
Our complex `buid.rs` scripts come to bite us again

* Closes #5168

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5170)
- [Docs
preview](https://rerun.io/preview/3bebf6d5b54bbd4a0f616cba19ea16892e703378/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3bebf6d5b54bbd4a0f616cba19ea16892e703378/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf pushed a commit that referenced this issue Feb 12, 2024
Our complex `buid.rs` scripts come to bite us again

* Closes #5168

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5170)
- [Docs
preview](https://rerun.io/preview/3bebf6d5b54bbd4a0f616cba19ea16892e703378/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3bebf6d5b54bbd4a0f616cba19ea16892e703378/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🦀 Rust API Rust logging API 🚢 CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant