Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using rerun crate as a dependency on CI #5170

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 12, 2024

Our complex buid.rs scripts come to bite us again

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🦀 Rust API Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) include in changelog labels Feb 12, 2024
@emilk emilk force-pushed the emilk/detect-rerun-ci branch from 0d7123f to 93be00c Compare February 12, 2024 10:47
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! let's see what ci says

@emilk emilk marked this pull request as ready for review February 12, 2024 10:55
@emilk emilk merged commit 1a31c3b into main Feb 12, 2024
40 of 41 checks passed
@emilk emilk deleted the emilk/detect-rerun-ci branch February 12, 2024 11:11
Wumpf pushed a commit that referenced this pull request Feb 12, 2024
Our complex `buid.rs` scripts come to bite us again

* Closes #5168

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5170/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5170)
- [Docs
preview](https://rerun.io/preview/3bebf6d5b54bbd4a0f616cba19ea16892e703378/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3bebf6d5b54bbd4a0f616cba19ea16892e703378/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users can't build rerun crate on their CI
2 participants