Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary Camera space created in structure from motion scene #5258

Closed
Wumpf opened this issue Feb 23, 2024 · 0 comments · Fixed by #5266
Closed

Unnecessary Camera space created in structure from motion scene #5258

Wumpf opened this issue Feb 23, 2024 · 0 comments · Fixed by #5266
Assignees
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Milestone

Comments

@Wumpf
Copy link
Member

Wumpf commented Feb 23, 2024

see
https://app.rerun.io/pr/5249/index.html

image

Related to

(but I think I already found a different separate bug source here)

@Wumpf Wumpf added 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Feb 23, 2024
@Wumpf Wumpf added this to the 0.13.1 milestone Feb 23, 2024
@Wumpf Wumpf self-assigned this Feb 23, 2024
Wumpf added a commit that referenced this issue Feb 26, 2024
#5266)

### What

* Fixes #5258

The mechanism we used for determining whether a "recommended" space view
is redundant was flawed in several ways, causing it to be order hash map
order dependent among other things.

Small improvement to 3d space view heuristic that stop it from
considering subspaces with ViewCoordinates.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5266/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5266/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5266/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5266)
- [Docs
preview](https://rerun.io/preview/8cce4d41110675bca314b675d962644ea0fdf394/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/8cce4d41110675bca314b675d962644ea0fdf394/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant