Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic redundancy check for space view spawning heuristic #5266

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 23, 2024

What

The mechanism we used for determining whether a "recommended" space view is redundant was flawed in several ways, causing it to be order hash map order dependent among other things.

Small improvement to 3d space view heuristic that stop it from considering subspaces with ViewCoordinates.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Feb 23, 2024
@Wumpf Wumpf requested a review from jleibs February 23, 2024 15:21
Copy link
Member Author

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built this in pair programming together with @jleibs and reviewed it myself now again. Looking still good after a couple of days, so merging (;

crates/re_viewport/src/viewport.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 4e1978d into main Feb 26, 2024
8 of 11 checks passed
@Wumpf Wumpf deleted the andreas/fix-redundant-space-view-handling branch February 26, 2024 09:12
@Wumpf Wumpf changed the title Fix indeterministic redundancy check for space view spawning heuristic Fix non-deterministic redundancy check for space view spawning heuristic Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary Camera space created in structure from motion scene
1 participant