Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing a data result sometimes duplicates the space view #5404

Closed
abey79 opened this issue Mar 5, 2024 · 0 comments · Fixed by #5419
Closed

Removing a data result sometimes duplicates the space view #5404

abey79 opened this issue Mar 5, 2024 · 0 comments · Fixed by #5419
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Milestone
0.15

Comments

@abey79
Copy link
Member

abey79 commented Mar 5, 2024

Repro:

  • structure from motion
  • reset blueprint
  • remove points from the 3D space view

That space view gets duplicated:

remove_entity_bug.mp4
@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release labels Mar 5, 2024
@abey79 abey79 added this to the 0.15 milestone Mar 5, 2024
@abey79 abey79 mentioned this issue Mar 5, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue Mar 6, 2024
@abey79
More context menu 3: add support for removing DataResult from a spa…
70fc212 
…ce view (#5407)

### What

As the title says ☝🏻 

Will easily trigger:
- #5404
- #5406


<img width="321" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/e996ade1-2ad7-42a5-8b9a-852149d653a3">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5407/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5407/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5407/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5407)
- [Docs
preview](https://rerun.io/preview/4a94ddc1c02addd3e7a45a9241dcf57eade1df91/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4a94ddc1c02addd3e7a45a9241dcf57eade1df91/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf mentioned this issue Mar 7, 2024
Merged
5 tasks
@Wumpf Wumpf self-assigned this Mar 7, 2024
Wumpf added a commit that referenced this issue Mar 8, 2024
@Wumpf
Improved tracking of which space views were generated by a heuristic (#…
e66438b 
…5419)

### What

* Fixes #5404

We now track haches of all "recommended" space views that we spawned so
far. Seems to work much more reliably so far than anything else we had
so far.
Natrually, I kept the "is this is a redundant space view" logic since
it's still useful to have around both to figure duplicates within a set
of recommendation and to figure out if user created space views cover
what the heuristic suggests.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5419/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5419/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5419/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5419)
- [Docs
preview](https://rerun.io/preview/bd21f004abd144d1e57e7f12a7dd9f0bbfc57bf5/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bd21f004abd144d1e57e7f12a7dd9f0bbfc57bf5/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Improved tracking of which space views were generated by a heuristic rerun-io/rerun
2 participants
@Wumpf @abey79