Improved tracking of which space views were generated by a heuristic #5419
Conversation
…tities_determined_by_user
|
drafting it: testing it again there seems to be something wrong |
|
huh, that was a bit tough to get my head around what was going on, but figured it out! |
crates/re_types/definitions/rerun/blueprint/archetypes/viewport_blueprint.fbs
Outdated
Show resolved
Hide resolved
| /// Hashes of all recommended space views the viewer has already added and that should not be added again. | ||
| /// | ||
| /// This is an internal field and should not be set usually. | ||
| /// If you want the viewer from stopping to add space views, you should set `auto_space_views` to `false`. | ||
| /// | ||
| /// The viewer uses this to determine whether it should keep adding space views. | ||
| past_viewer_recommendations: [rerun.blueprint.components.ViewerRecommendationHash] ("attr.rerun.component_optional", nullable, order: 6000); |
There was a problem hiding this comment.
We should split internal implementation details like this out into a separate unlisted archetype (maybe another sub-archetype?) -- there's no reason for a user to be aware of this.
There was a problem hiding this comment.
we could add a hide attribute, but honestly I think it's kinda nice to be aware of this 🤔
Like now we have for the first time ever a way to document the viewer's behavior and in particular how it interacts with whatever you do
There was a problem hiding this comment.
For an advanced user looking at code, sure, they can look at the ViewportBlueprintInternalState archetype.
For a non-advanced user just trying to understand the blueprint API, this just makes things more confusing.
There was a problem hiding this comment.
Not convinced, but I'll create an issue for it since I don't want to solve this on this PR
…out` and `auto_space_views`
What
We now track haches of all "recommended" space views that we spawned so far. Seems to work much more reliably so far than anything else we had so far.
Natrually, I kept the "is this is a redundant space view" logic since it's still useful to have around both to figure duplicates within a set of recommendation and to figure out if user created space views cover what the heuristic suggests.
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io