Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

certain blueprints cause spam when selecting space view: "Could not find root data result for Space View SpaceViewId(...) #5568

Closed
jleibs opened this issue Mar 18, 2024 · 0 comments · Fixed by #5571
Closed

certain blueprints cause spam when selecting space view: "Could not find root data result for Space View SpaceViewId(...) #5568

jleibs opened this issue Mar 18, 2024 · 0 comments · Fixed by #5571
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team
Milestone
0.15

Comments

@jleibs
Copy link
Member

jleibs commented Mar 18, 2024 •
edited
Loading

To reproduce

[2024-03-18T18:34:50Z ERROR re_viewer::ui::selection_panel] Could not find root data result for Space View SpaceViewId(ef179e60-0bac-4dad-953f-a261d3c7414f)
[2024-03-18T18:34:50Z ERROR re_viewer::ui::selection_panel] Could not find root data result for Space View SpaceViewId(ef179e60-0bac-4dad-953f-a261d3c7414f)
[2024-03-18T18:34:50Z ERROR re_viewer::ui::selection_panel] Could not find root data result for Space View SpaceViewId(ef179e60-0bac-4dad-953f-a261d3c7414f)
@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team 🟦 blueprint The data that defines our UI labels Mar 18, 2024
@jleibs jleibs added this to the 0.15 milestone Mar 18, 2024
@jleibs jleibs changed the title certain blueprints cause spam when selectoin space view: "Could not find root data result for Space View SpaceViewId(...) certain blueprints cause spam when selecting space view: "Could not find root data result for Space View SpaceViewId(...) Mar 18, 2024
@jleibs jleibs mentioned this issue Mar 18, 2024
Closed
5 tasks
@Wumpf Wumpf mentioned this issue Mar 19, 2024
Merged
5 tasks
Wumpf pushed a commit that referenced this issue Mar 19, 2024
@jleibs
Make space view use its own data-result when editing visible history (#…
91439ed 
…5571)

### What
Also renamed the API because root_data_result is **very** overloaded.

* Fixes #5568

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5571/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5571/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5571/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5571)
- [Docs
preview](https://rerun.io/preview/5f8ed4cf08e9cbc8b723284d2af622c664ede60c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/5f8ed4cf08e9cbc8b723284d2af622c664ede60c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team
Projects
None yet
Milestone
0.15
1 participant
@jleibs