Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log spam on invalid invalid query #5566

Closed
wants to merge 1 commit into from

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 18, 2024

What

Fixes recent regression of getting Could not find root data result for Space View SpaceViewId(2e0664ef-251a-4813-9eae-f728818bf507) spamed when editing the query expressions. E.g. this would trigger when changing a query from + $origin/** to + $origin/*

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 🦟 regression A thing that used to work in an earlier release exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 18, 2024
@Wumpf Wumpf force-pushed the andreas/fix-logspam-on-invalid-query branch from 73a10c7 to ef13e85 Compare March 18, 2024 17:25
@@ -855,7 +855,7 @@ fn blueprint_ui_for_space_view(
.root_handle()
.and_then(|root| query_result.tree.lookup_result(root))
else {
re_log::error!("Could not find root data result for Space View {space_view_id:?}");
// This can happen when the query was invalid for some reason.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query doesn't even need to be valid... just empty I think is sufficient to hit this

@jleibs
Copy link
Member

jleibs commented Mar 18, 2024

Reviewing this led me to instead implement: #5571, which I think is the preferable fix since it avoids this query (that didn't need to be there) all together.

This is important for still being able to edit the visible history on an empty space view.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 19, 2024

Closing in favor of that one

@Wumpf Wumpf closed this Mar 19, 2024
@Wumpf Wumpf deleted the andreas/fix-logspam-on-invalid-query branch March 19, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release
Projects
None yet
2 participants