Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python (blueprint) API for setting component defaults #6539

Closed
Wumpf opened this issue Jun 11, 2024 · 0 comments · Fixed by #6545
Closed

Python (blueprint) API for setting component defaults #6539

Wumpf opened this issue Jun 11, 2024 · 0 comments · Fixed by #6545
Assignees
@jleibs
Labels
🟦 blueprint The data that defines our UI 🐍 Python API Python logging API

Comments

@Wumpf
Copy link
Member

Wumpf commented Jun 11, 2024

Settable blueprint provided defaults per space view are coming in:

We also want to be able to set this from the Python api, probably something like this:

rrb.Blueprint(rrb.SpatialView3D(origin="/", defaults=[rr.Color(123), rr.CameraPlaneDistance(9001)])

(not final, consider this pseudo code)

Strongly related to
@Wumpf Wumpf added 🐍 Python API Python logging API 🟦 blueprint The data that defines our UI labels Jun 11, 2024
@jleibs jleibs self-assigned this Jun 11, 2024
@jleibs jleibs mentioned this issue Jun 12, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue Jun 12, 2024
@jleibs
Introduce API for setting view defaults from python (#6545)
3010d2f 
### What
- Resolves: #6539
- Builds on top of: #6543
(no-merge until that lands)

Just a bit of plumbing to write all the provided defaults to the correct
location in the blueprint.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6545?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6545?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6545)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
🟦 blueprint The data that defines our UI 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce API for setting view defaults from python rerun-io/rerun
2 participants
@Wumpf @jleibs