Introduce a mechanism for blueprint-provided defaults #6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Jun 11, 2024
Comment on lines
+42
to
+44
| // TODO(jleibs): This doesn't work when the component set contains empty results. | ||
| // This means we over-query for defaults that will never be used. | ||
| // component_set.retain(|component| !results.components.contains_key(component)); |
There was a problem hiding this comment.
on the bright side this means that this object contains more of what the ui may want to display 🤔
Would it be worth to poke results some more to reduce the query size? I reckon you made the call that it doesn't
| @@ -0,0 +1,241 @@ | |||
| use std::collections::{BTreeMap, BTreeSet}; | |||
|
|
|||
There was a problem hiding this comment.
quite a bit of unfortunate copy & paste in here from component override ui, but probably better than the work intensive alternative with dubious future outlook 👍
There was a problem hiding this comment.
That was my thought -- I think they both get thrown away and replaced with something universal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There's quite a bit of annoying logic in here related to when and how we figure out whether a component is actually empty, motivating: #6536
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.