Make image transparency explicit & split image visualizers #6548
Assignees
Labels
🍏 primitives
Relating to Rerun primitives
📺 re_viewer
affects re_viewer itself
🚜 refactor
Change the code, not the functionality
Milestone
Comments
Wumpf
added
📺 re_viewer
26 tasks
|
This dramatically improves the user experience of working with the new visualizer/override UI. |
Wumpf
added a commit
that referenced
this issue
Jun 25, 2024
### What Image opacity (for layering images) is now an exposed component that can be set from blueprint & data store. Heuristic for opacity is a lot simplified: * stacked images will no longer be made transparent in general * only segmentation image will use 0.5 opacity as a fallback if there is any other image in the scene Demonstrated here: https://github.com/rerun-io/rerun/assets/1220815/8b133062-01cf-4bca-bfdc-1cec8c1457ae --- * prerequisite for #6548 * almost solves #2192 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6635?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6635?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6635) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
This was referenced Jun 25, 2024
Merged
5 tasks
Wumpf
added a commit
that referenced
this issue
Jun 28, 2024
… to arrow2d archetype (#6644) ### What Making `DrawOrder` editable resulting in changing the depth offset system (it has to read overrides etc.). This in turn solved the bug of `fallback` not showing correctly for `DrawOrder` and also giving everything a draw order via the fallback system. This + collecting visualizers into an order preserving set instead of a hashmap fixes flickering! With all these refactors I included `Arrows2D` as well, so the only thing was left is to add a line to codegen in order to fix it seemingly not supporting draw order. * Fixes #5549 * Fixes #6600 * Part of #6548 * without this change set the separated image visualizers show flickering as well ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6644?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6644?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6644) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today, we automatically determine a transparency & implicit order between images in a stack.
This ties all three image types (regular, depth, segmentation) together into single visualizer which is hard to take apart. We do want to take it apart to make it easier to express their respective archetype realationships (and difference in actual visualization).
Furthermore, the implicit transparency won't scale well into a world where we have 2D transforms.
Instead, we should use transparency from color (if specified) and an additional
Opacitycomponent. For simplicity,Opacityalways defaults to 1.0, except for segmentation images where we would set it to 0.5 unless the scene has no other images.This in turn allows us to split up these three visualizers.
Related to
The text was updated successfully, but these errors were encountered: