-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Image visualizer into Image/DepthImage/SegmentationImage #6654
Conversation
Deployed docs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how this worked out!
I agree the duplication is generally clearer than the mega-visualizer.
One observation (not actionable yet): the 2D view of the depth image visualizer still feels slightly strange to me, since it basically falls back to acting like a normal image and depth-meter, fill ratio, etc. stop being applicable. I'm still wondering if ther'es an opportunity to have the 2D view end up using the normal Image visualizer in this case (once we support colormaps in all images)
💯 felt the same about it! |
… -> fixes incorrect hover preview
8735ef9
to
99a4fd8
Compare
What
Lots of copy & paste between the three visualizers left. Didn't want to remove it entirely to not make it too hard to have them diverge more in the future. But thanks to some clean-up passes it's not too bad (imho).
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.