Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ChildToParent & ParentToChild enum aliases for TransformRelation #6943

Open
Wumpf opened this issue Jul 18, 2024 · 0 comments
Open

Allow ChildToParent & ParentToChild enum aliases for TransformRelation #6943

Wumpf opened this issue Jul 18, 2024 · 0 comments
Labels
codegen/idl enhancement New feature or request 🐍 Python API Python logging API

Comments

@Wumpf
Copy link
Member

Wumpf commented Jul 18, 2024

At least in Python we should also offer ChildToParent and ParentToChild as valid variants since this is what a lot of people have in their code. We would however map that to above TransformRelation.

The ideal solution for this would be to allow aliases on our enum types.

@Wumpf Wumpf added enhancement New feature or request 🐍 Python API Python logging API codegen/idl labels Jul 18, 2024
Wumpf added a commit that referenced this issue Jul 22, 2024
### What

* Based on  #6929
* Important milestone towards #6831
    * only missing the planned out of tree handling
    * and some other related tickets .. ;)
* Fixes #6863
* created follow-up issue for the aliases which I didn't get to:
#6943

Automated test + test again planet system

![image](https://github.com/user-attachments/assets/15dbda23-7b62-432a-a4a8-cfacf448c2a8)

Still need some more test & a checklist for this blob of changes, as
well as a more thorough pass on the migration guide!

### Checklist
* [x] main checks
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6944?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6944?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/6944)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl enhancement New feature or request 🐍 Python API Python logging API
Projects
None yet
Development

No branches or pull requests

1 participant