-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataframe view: column visibility editor #7067
Comments
Decision making update:
How? We'll embrace this weirdness in the context of an already seriously weird view and see how this feels/how users react :) |
### What Add a hook so views can have additional buttons in the title bar. Unblocks #4466. Background: will be used for column show/hide UI of the dataframe UI. We had ample discussion on doing so, how different it is from other views, and on how we accept that (and eventually embrace that in other views). See eg this comment: #7067 (comment) <img width="770" alt="image" src="https://github.com/user-attachments/assets/05a533ae-62cb-40ba-bfad-f5fb4fc94188"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7438?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7438?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7438) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
### What * Closes #7067 * Builds on #7438 Add the possibility to control the visibility of column: - Time columns (except the one corresponding to the query) and component columns can be hidden by clicking on the on-hover button in their header. - A new button in the view title bar with a popup to show/hide any column. This also fixes a red warning showing up when latest-at queries return 0 rows (see #7449 for background). Note to reviewer: the meat is in `space_view_class.rs`, which is ofc hidden by default by GitHub. https://github.com/user-attachments/assets/d2b55c63-53db-46dd-9339-b10af98a073b ### TODO - [x] Fix bad sizing of the popup menu ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7453?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7453?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7453) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
SpaceViewClass
to allow adding "stuff" to the view title barConcept:
Screen.Recording.2024-09-11.at.15.32.07.mp4
The text was updated successfully, but these errors were encountered: