Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe column visibility can now be controlled #7453

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Sep 19, 2024

What

Add the possibility to control the visibility of column:

  • Time columns (except the one corresponding to the query) and component columns can be hidden by clicking on the on-hover button in their header.
  • A new button in the view title bar with a popup to show/hide any column.

This also fixes a red warning showing up when latest-at queries return 0 rows (see #7449 for background).

Note to reviewer: the meat is in space_view_class.rs, which is ofc hidden by default by GitHub.

column_show_hide.mp4

TODO

  • Fix bad sizing of the popup menu

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog feat-dataframe-view Everything related to the dataframe view labels Sep 19, 2024
@abey79 abey79 marked this pull request as ready for review September 20, 2024 08:51
@emilk emilk self-requested a review September 23, 2024 06:44
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@abey79 abey79 merged commit f287587 into main Sep 23, 2024
39 checks passed
@abey79 abey79 deleted the antoine/dataframe-column-visibility branch September 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dataframe-view Everything related to the dataframe view ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataframe view: column visibility editor
2 participants