Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test video playback with video part of pinhole camera & add release_checklist item #7543

Closed
Wumpf opened this issue Sep 27, 2024 · 1 comment · Fixed by #7544
Closed

Test video playback with video part of pinhole camera & add release_checklist item #7543

Wumpf opened this issue Sep 27, 2024 · 1 comment · Fixed by #7544
Assignees
Labels
🔨 testing testing and benchmarks 🎞️ video

Comments

@Wumpf
Copy link
Member

Wumpf commented Sep 27, 2024

It should just work out of the box, but we didn't test it out properly so who knows what we'll find!

  • create a pinhole camera somewhere in 3D space
    • bonus points for moving the camera around over time
  • log a video at the same path the camera sits
    • check the video_auto_frames.py snippet to learn how that's done

⚠️ make sure to test with loading delays - the interaction with #7541 is likely not smooth!

@Wumpf Wumpf added 🔨 testing testing and benchmarks 🎞️ video labels Sep 27, 2024
@emilk
Copy link
Member

emilk commented Sep 27, 2024

Let's make a reusable example or test for this and commit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 testing testing and benchmarks 🎞️ video
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants