Show spinner icon while waiting for video decoder #7541
Conversation
emilk
added
ui
There was a problem hiding this comment.
It plays it directly, even if there is only a single frame of delay in decoding. I thought this could be annoying, but I think it feels great, and it is a lot simpler than keeping track of for how long we've been waiting.
I concur, this is a lot better than expected. I even like it after playing around with it a bit!
Follow-up ticket for testing this (and .. everything else!) with 3D views: #7543
looking at the way we insert the 2d spinner here I'm skeptical this will work out of the box, but let's take this separately
| @@ -174,4 +174,15 @@ impl VisualizerCollection { | |||
| ) -> impl Iterator<Item = (ViewSystemIdentifier, &dyn VisualizerSystem)> { | |||
| self.systems.iter().map(|s| (*s.0, s.1.as_ref())) | |||
| } | |||
|
|
|||
| /// Iterate over all visualizer data that can be downcast to the given type. | |||
| pub fn iter_visualizer_data<SpecificData: 'static>( | |||
There was a problem hiding this comment.
neat, liking this much better than the global method
| let min = top_left_corner_position; | ||
| let max = top_left_corner_position + extent_u + extent_v; | ||
| let center = 0.5 * (min + max); | ||
| let diameter = (max - min).truncate().abs().min_element(); |
There was a problem hiding this comment.
this likely breaks in 3D #7543
.. but I'm actually not even sure, gotta check how we place labels on 3D points. Likely we'll have to do a similar thing!
What
This uses the default
egui::Spinnerloading animation.It plays it directly, even if there is only a single frame of delay in decoding. I thought this could be annoying, but I think it feels great, and it is a lot simpler than keeping track of for how long we've been waiting.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.