Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video loader spinner in 3D views #7544

Merged
merged 10 commits into from
Oct 1, 2024
Merged

Fix video loader spinner in 3D views #7544

merged 10 commits into from
Oct 1, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Sep 27, 2024 •
edited by github-actions bot
Loading

What

image (image via @Wumpf : Wasn't able to catch the spinner because it disappeared right away)

Test:

pixi run -e examples python3 tests/python/release_checklist/check_video.py

https://rerun.io/viewer/pr/7544?url=https%3A%2F%2Fstatic.rerun.io%2Frrd%2F0.19.0-alpha.1%2Bdev%2Fdata_dca3624dd9631b0208ab10257ec9495903699237.rrd

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Sep 27, 2024
@emilk emilk marked this pull request as ready for review September 27, 2024 15:51
@Wumpf Wumpf self-requested a review September 28, 2024 12:12
Wumpf
Wumpf approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!
transform code was reasonably easy to follow. Automatic asset download would be really nice

tests/python/release_checklist/main.py Outdated
@@ -15,6 +15,9 @@ def log_checks(args: argparse.Namespace) -> None:
modules = [basename(f)[:-3] for f in modules if isfile(f) and basename(f).startswith("check_")]

for module in modules:
if args.skip_checks_with_assets and "check_video" in module:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to make the list of checks with assets already a list or a property. Hard to find otherwise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and on else we might just invoke the download script, then the user doesn't have to!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try it!

@emilk emilk merged commit 49fee63 into main Oct 1, 2024
34 checks passed
@emilk emilk deleted the emilk/fix-3d-spinner branch October 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test video playback with video part of pinhole camera & add release_checklist item
2 participants
@emilk @Wumpf