Publish our rav1d fork, or get it merged upstream #7588
Assignees
Labels
Milestone
Comments
7 tasks
Wumpf
added a commit
that referenced
this issue
Oct 11, 2024
### What Related to * #7671 * #7605 * #7588 Biting the bullet and split the feature on our rav1d fork: rerun-io/re_rav1d@emilk/dav1d-interface...rerun-io:rav1d:andreas/disable-asm-linux Testing done: * wsl linux release build works now (didn't before) * windows build still works * shows no-asm warning if compiled with out nasm * works otherwise * added a `panic` under `cfg(asm)` in one of the interface functions (now removed again) .. then: * linux still worked * windows hit that panic when compiled with nasm feature ### Checklist * [x] main ci passes * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7694?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7694?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7694) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have our own fork of
rav1dat https://github.com/rerun-io/rav1d which adds a Rust interface.Hopefully the changes can get upstreamed and merged:
dav1das the Rust API memorysafety/rav1d#1362But if not (or not in time), we should publish our fork as
re_rav1d.The text was updated successfully, but these errors were encountered: