Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable (n)asm rav1d on Mac & Windows via nasm feature #7694

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 11, 2024

What

Related to

Biting the bullet and split the feature on our rav1d fork:
rerun-io/re_rav1d@emilk/dav1d-interface...rerun-io:rav1d:andreas/disable-asm-linux

Testing done:

  • wsl linux release build works now (didn't before)
  • windows build still works
    • shows no-asm warning if compiled with out nasm
    • works otherwise
  • added a panic under cfg(asm) in one of the interface functions (now removed again) .. then:
    • linux still worked
    • windows hit that panic when compiled with nasm feature

Checklist

  • main ci passes
  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🚀 performance Optimization, memory use, etc 🪟 windows Problems specific to the Windows OS 🐧 linux Linux-specific problems exclude from changelog PRs with this won't show up in CHANGELOG.md 🍎 MacOS Issues specifically about MacOS support 🎞️ video labels Oct 11, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Oct 11, 2024

@rerun-bot full-check

Copy link

@emilk emilk self-requested a review October 11, 2024 14:22
crates/store/re_video/Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@Wumpf Wumpf merged commit ad631cd into main Oct 11, 2024
18 of 19 checks passed
@Wumpf Wumpf deleted the andreas/enable-nasm-everywhere-but-linux branch October 11, 2024 14:30
teh-cmc added a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 MacOS Issues specifically about MacOS support exclude from changelog PRs with this won't show up in CHANGELOG.md 🐧 linux Linux-specific problems 🚀 performance Optimization, memory use, etc 🎞️ video 🪟 windows Problems specific to the Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants